Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flush existing connections on steal #1029

Closed
aviramha opened this issue Feb 8, 2023 · 2 comments
Closed

flush existing connections on steal #1029

aviramha opened this issue Feb 8, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@aviramha
Copy link
Member

aviramha commented Feb 8, 2023

Bug Description

on calico k3s we found out that steal doesn't work until established connections are reset, probably due to different behavior in that setup.
possible solution is to have conntrack binary in our image and call conntrack -F on each stolen port after adding the rule.

**this should be controlled via env var, at least for the first version, then decide if to make it enabled by default **

Steps to Reproduce

calico + k3s

Backtrace

No response

Relevant Logs

No response

Your operating system and version

n/a

Local process

n/a

Local process version

No response

Additional Info

No response

@aviramha aviramha added the bug Something isn't working label Feb 8, 2023
@meowjesty meowjesty self-assigned this Feb 8, 2023
@aviramha
Copy link
Member Author

aviramha commented Feb 12, 2023

This fixed their issue. Leaving this open until we decide if to have it this way by default.

Can be enabled right now using

"agent": {
"flush_connections": true
}

@eyalb181
Copy link
Member

@meowjesty Discussed this with @aviramha , can you please change it to default to true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants