Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): always ensure image definitions #296

Merged
merged 2 commits into from
Apr 19, 2022
Merged

fix(azure): always ensure image definitions #296

merged 2 commits into from
Apr 19, 2022

Conversation

jkoelker
Copy link
Contributor

@jkoelker jkoelker commented Apr 6, 2022

What problem does this PR solve?:

Two misc fixes I found while working on getting CI setup.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@jkoelker jkoelker requested a review from a team April 6, 2022 06:06
@jkoelker jkoelker self-assigned this Apr 6, 2022
@github-actions github-actions bot added the fix label Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

File Coverage
All files 15%
pkg/ansible/runner.go 0%
pkg/app/artifacts.go 0%
pkg/app/build.go 1%
pkg/app/config.go 50%
pkg/app/errors.go 0%
pkg/app/provision.go 0%
pkg/app/root.go 0%
pkg/app/validate.go 0%
pkg/appansible/io.go 0%
pkg/appansible/playbook.go 0%
pkg/azure/azure.go 0%
pkg/logging/logger.go 0%
pkg/packer/manifest.go 0%
pkg/packer/packer.go 0%
pkg/stringutil/rand.go 0%
pkg/version/info.go 8%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 94f44bc

Image definitions need to be created even for "DryRun"s for packer to
place the image somewhere.
@github-actions github-actions bot added fix and removed fix labels Apr 14, 2022
@alejandroEsc
Copy link
Contributor

@jkoelker is this relevant still?

@jkoelker
Copy link
Contributor Author

@jkoelker is this relevant still?

@alejandroEsc Yep it totes is.

@jkoelker jkoelker merged commit 861aafa into main Apr 19, 2022
@jkoelker jkoelker deleted the jk/azure_fixes branch April 19, 2022 23:45
@alejandroEsc
Copy link
Contributor

thanks @joejulian for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants