-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(make): reorg build targets and add Azure #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d23ca04
to
ade9f90
Compare
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9e8ec95 |
1f2e405
to
ca1b1f0
Compare
3964b72
to
17ee12a
Compare
0a814c3
to
e511b3d
Compare
supershal
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring code and make it extensible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
DRY up the current build targets by using
pattern
targets.The basis is a
build-${provider}-${distro}-${version}
pattern target that will parse out the parts from the target name. Other pattern targets end up calling this target setting the variousADDITIONAL_OVERRIDES
orADDITIONAL_ARGS
. They then provide the following pattern targets:${provider}-${distro}-${version}_fips
${provider}-${distro}-${version}_offline
${provider}-${distro}-${version}_offline-fips
${provider}-${distro}-${version}_nvidia
All the existing targets are now just aliases to the dynamic pattern targets. In the future if we stay consistent with the image name pattern we have for aws/azure/vsphere, we won't have to have any alias patterns and can just setup CI to call the pattern targets directly.
I pulled the images targets out into their own makefile as well. The root one is getting kinda gnarly.
Adds Azure build using these this new target pattern.
Which issue(s) does this PR fix?:
*https://jira.d2iq.com/browse/D2IQ-85258
Special notes for your reviewer:
Does this PR introduce a user-facing change?: