Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(make): reorg build targets and add Azure #297

Merged
merged 7 commits into from
Apr 28, 2022
Merged

chore(make): reorg build targets and add Azure #297

merged 7 commits into from
Apr 28, 2022

Conversation

jkoelker
Copy link
Contributor

@jkoelker jkoelker commented Apr 6, 2022

What problem does this PR solve?:

DRY up the current build targets by using pattern targets.

The basis is a build-${provider}-${distro}-${version} pattern target that will parse out the parts from the target name. Other pattern targets end up calling this target setting the various ADDITIONAL_OVERRIDES or ADDITIONAL_ARGS. They then provide the following pattern targets:

${provider}-${distro}-${version}_fips
${provider}-${distro}-${version}_offline
${provider}-${distro}-${version}_offline-fips
${provider}-${distro}-${version}_nvidia

All the existing targets are now just aliases to the dynamic pattern targets. In the future if we stay consistent with the image name pattern we have for aws/azure/vsphere, we won't have to have any alias patterns and can just setup CI to call the pattern targets directly.

I pulled the images targets out into their own makefile as well. The root one is getting kinda gnarly.

Adds Azure build using these this new target pattern.

Which issue(s) does this PR fix?:

*https://jira.d2iq.com/browse/D2IQ-85258

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@jkoelker jkoelker self-assigned this Apr 6, 2022
@jkoelker jkoelker force-pushed the jk/azure_ci branch 2 times, most recently from d23ca04 to ade9f90 Compare April 6, 2022 06:44
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

File Coverage
All files 15%
pkg/ansible/runner.go 0%
pkg/app/artifacts.go 0%
pkg/app/build.go 1%
pkg/app/config.go 49%
pkg/app/errors.go 0%
pkg/app/provision.go 0%
pkg/app/root.go 0%
pkg/app/validate.go 0%
pkg/appansible/io.go 0%
pkg/appansible/playbook.go 0%
pkg/azure/azure.go 0%
pkg/logging/logger.go 0%
pkg/packer/manifest.go 0%
pkg/packer/packer.go 0%
pkg/stringutil/rand.go 0%
pkg/version/info.go 8%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 9e8ec95

@jkoelker jkoelker force-pushed the jk/azure_ci branch 5 times, most recently from 1f2e405 to ca1b1f0 Compare April 10, 2022 02:51
@jkoelker jkoelker force-pushed the jk/azure_ci branch 2 times, most recently from 3964b72 to 17ee12a Compare April 10, 2022 04:04
@jkoelker jkoelker force-pushed the jk/azure_ci branch 4 times, most recently from 0a814c3 to e511b3d Compare April 24, 2022 13:58
@jkoelker jkoelker changed the title chore(make): reorg build targets chore(make): reorg build targets and add Azure Apr 24, 2022
@jkoelker jkoelker marked this pull request as ready for review April 24, 2022 17:18
@jkoelker jkoelker requested a review from a team April 24, 2022 17:18
Copy link
Collaborator

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring code and make it extensible.

@supershal supershal requested a review from a team April 26, 2022 22:20
@jkoelker jkoelker merged commit 9ff21c1 into main Apr 28, 2022
@jkoelker jkoelker deleted the jk/azure_ci branch April 28, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants