chore: update awsebscsiprovisioner chart #492

joejulian · 2020-03-06T04:42:43Z

Bump aws-ebs-csi-driver from 0.4.0 to 0.5.0

filename	sha512 hash
v0.5.0.zip	`c53327e090352a7f79ee642dbf8c211733f4a2cb78968ec688a1eade55151e65f1f97cd228d22168317439f1db9f3d2f07dcaa2873f44732ad23aaf632cbef3a`
v0.5.0.tar.gz	`ec4963d34c601cdf718838d90b8aa6f36b16c9ac127743e73fbe76118a606d41aced116aaaab73370c17bcc536945d5ccd735bc5a4a00f523025c8e41ddedcb8`

Add a cmdline option to add extra volume tags (#353, @jieyu)
Switch to use kustomize for manifest (#360, @leakingtapan)
enable users to set ec2-endpoint for nonstandard regions (#369, @amdonov)
Add standard volume type (#379, @leakingtapan)
Update aws sdk version to enable EKS IAM for SA (#386, @leakingtapan)
Implement different driver modes and AWS Region override for controller service (#438, @rfranzke)
Add manifest files for snapshotter 2.0 (#452, @leakingtapan)
Return success if instance or volume are not found (#375, @bertinatto)
Patch k8scsi sidecars CVE-2019-11255 (#413, @jnaulty)
Handle mount flags in NodeStageVolume (#430, @bertinatto)
Run upstream e2e test suites with migration (#341, @wongma7)
Use new test framework for test orchestration (#359, @leakingtapan)
Update to use 1.16 cluster with inline test enabled (#362, @leakingtapan)
Enable leader election (#380, @leakingtapan)
Update go mod and mount library (#388, @leakingtapan)
Refactor NewCloud by pass in region (#394, @leakingtapan)
helm: provide an option to set extra volume tags (#396, @jieyu)
Allow override for csi-provisioner image (#401, @gliptak)
Enable volume expansion e2e test for CSI migration (#407, @leakingtapan)
Swith to use kops 1.16 (#409, @leakingtapan)
Added tolerations for node support (#420, @zerkms)
Update helm chart to better match available values and add the ability to add annotations (#423, @krmichel)
[helm] Also add toleration support to controller (#433, @jyaworski)
Add ec2:ModifyVolume action (#434, @zodiac12k)
Schedule the EBS CSI DaemonSet on all nodes by default (#441, @pcfens)

bump livenessprobe from 1.1.0 to 2.0.0

Changes since v1.1.0

Action Required

Introduce V(5) on the health check begin/success log lines to allow filtering of these entries from logs. If you would like to retain these log entries the action required would be to set -v==5 or higher for the livenessprobe container. (#57, @stefansedich)
Deprecated "--connection-timeout" argument has been removed. (#59, @msau42)

Other Notable Changes

Fix nil pointer bug when driver responds with not ready (#58, @scuzhanglei)
Migrated to Go modules, so the source builds also outside of GOPATH. (#53, @pohly)

bump csi external-provisioner from 1.3.0 to 1.4.0

Changelog since v1.3.0

Deprecations

All external-provisioner versions < 1.4.0 are deprecated and will stop
functioning in Kubernetes v1.20. See
#323 and
k/k#80978 for more
details. Upgrade your external-provisioner to v1.4+ before Kubernetes v1.20.

New Features

None

Bug Fixes

Fixes migration scenarios for Topology, fstype, and accessmodes for the kubernetes.io/gce-pd in-tree plugin (#277, @davidz627)
Checks if volume content source is populated if creating a volume from a snapshot source. (#283, @zhucan)
Fixes issue when SelfLink removal is turned on in Kubernetes. (#323, @msau42)
CSI driver can return CreateVolumeResponse with size 0, which means unknown volume size.
In this case, Provisioner will use PVC requested size as PV size rather than 0 bytes (#271, @hoyho)
Fixed potential leak of volumes after CSI driver timeouts. (#312, @jsafrane)
Fixes issue where provisioner provisions volumes for in-tree PVC's which have not been migrated (#341, @davidz627)
Send the CSI volume_id instead of PVC Name to the csi-driver in volumeCreate when datasource is PVC (#310, @Madhu-1)
Fixes nil pointer derefence in log when migration turned on (#342, @davidz627)
Handle deletion of CSI migrated volumes (#273, @ddebroy)
Reduced logging noise of unrelated PVCs. Emit event on successful provisioning. (#351, @jsafrane)
Added extra verification of source Snapshot and PersistentVolumeClaim before provisioning. (#352, @jsafrane)

bump csi external-attacher from 1.2.0 to 1.2.1

Bug Fixes

Fixed handling of ControllerUnpublish errors. The attacher will retry to ControllerUnpublish a volume after any error except for NotFound. (fix FederatedTypeConfig for clusterrolebinding name #168, @jsafrane)

bump external-snapshotter from 1.1.0 to 1.2.2

Breaking Changes

Changes the API group name for the fake VolumeSnapshot object to "snapshot.storage.k8s.io" to be in-sync with the group name of the real VolumeSnapshot object. As a result, the generated interfaces for clientset and informers of VolumeSnapshot are also changed from "VolumeSnapshot" to "Snapshot". (Add cert-manager-setup chart, make dex + traefik use cert-manager issued certificates #123, @xing-yang)

NOTE: The shapshotter is not being used so these breaking changes have no user impact. The prior version that was included would not work with any of our supported Kubernetes versions.

New Features

Adds Finalizer on the snapshot source PVC to prevent it from being deleted when a snapshot is being created from it. (update kommander and opsportal charts #47, @xing-yang)

Other Notable Changes

Add Status subresource for VolumeSnapshot. (Update CONTRIBUTING.md to include extrasteps reference #121, @zhucan)
Cherry picks PR stable/awsebscsi: fix role not being created and add env to values #138: Prebound snapshots will work correctly with CSI drivers that does not support ListSnasphots.([catalog] chore: update crds and roles #156, @hakanmemisoglu)
Cherry picks PR Remove unnecessary hook declaration #172: Added extra verification of source PersistentVolumeClaim before creating snapshot.(reference mesosphere hosted image #173, @xing-yang)

bump external-resizer from 0.2.0 to 0.4.0

New Features

Add prometheus metrics to CSI external-resizer under the /metrics endpoint. This can be enabled via the "--metrics-address" and "--metrics-path" options. (Add branded assets back to landing page #67, @saad-ali)

Bug Fixes

Avoid concurrent processing of same PVCs (Makefile: set the url of chart repository #6, @mlmhl)
Exit on CSI gRPC conn loss (chore: fix ops portal and kommander charts #55, @ggriffiths)
Verify claimref associated with PVs before resizing (change all .storageclass.isDefault #57, @gnufied)

Other Notable Changes

Migrated to Go modules, so the source builds also outside of GOPATH. (dex-k8s-authenticator: avoid using subPath for the secret #60, @pohly)

jieyu · 2020-03-06T20:21:11Z

Thanks for doing this!

Maybe not in this PR, but could you please also bump the chart to the one that's shipped with 0.5.0?
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/tree/v0.5.0/aws-ebs-csi-driver

The updated chart includes some changes that we'll probably need (e.g., expose cmd flags allowing to attach static tags to every created volume, kubernetes-sigs/aws-ebs-csi-driver#396).

makkes · 2020-03-09T08:29:38Z

@joejulian should this still be wip? I guess it could be ready?!

joejulian · 2020-03-09T21:38:42Z

Yes, it was still wip. I had only made it through half the changes.

sebbrandt87 · 2020-03-14T15:55:41Z

https://jira.d2iq.com/browse/D2IQ-64990

hectorj2f

Are you sure non of the flags or properties have changed ?

stable/awsebscsiprovisioner/values.yaml

sebbrandt87 · 2020-03-16T16:34:45Z

stable/awsebscsiprovisioner/values.yaml


 snapshotter:
  # True if enable volume snapshot
  enabled: false
  image:
    repository: "quay.io/k8scsi/csi-snapshotter"
-    tag: "v1.1.0"
+    tag: "v1.2.2"


as soon as we update / support to 1.17 we need to switch to v2.
https://kubernetes-csi.github.io/docs/external-snapshotter.html

stable/awsebscsiprovisioner/values.yaml

sebbrandt87 · 2020-03-16T16:45:47Z

charts/stable/awsebscsiprovisioner/templates/daemonset.yaml

Line 34 in 147b6e2

- --endpoint=$(CSI_ENDPOINT)

We may should add the node as execution / binary args, so it is done upstream.

sebbrandt87 · 2020-03-16T16:48:01Z

ebs-plugin should get controller as execution / binary args, so it is done upstream.

snapshotter should get - --leader-election=true as argument
attacher should get - --leader-election=true and - --leader-election-type=leases as argument

provisioner should get https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/aws-ebs-csi-driver/templates/deployment.yaml#L94-L95

sebbrandt87 · 2020-03-17T21:31:51Z

Mar 14 10:35:05 ip-10-0-128-49.us-west-2.compute.internal kubelet[22146]: E0314 10:35:05.750404 22146 goroutinemap.go:150] Operation for "/var/lib/kubelet/plugins/ebs.csi.aws.com/csi.sock" failed. No retries permitted until 2020-03-14 10:35:13.750374648 +0000 UTC m=+20.368597010 (durationBeforeRetry 8s). Error: "RegisterPlugin error -- failed to get plugin info using RPC GetInfo at socket /var/lib/kubelet/plugins/ebs.csi.aws.com/csi.sock, err: rpc error: code = Unimplemented desc = unknown service pluginregistration.Registration"

This should be already solvable by adding the right / latest compabtible versions of the single CSI related container images to the AWS CSI charts we provide

@jieyu

@stefansedich

- Introduce V(5) on the health check begin/success log lines to allow filtering of these entries from logs. If you would like to retain these log entries the action required would be to set `-v==5` or higher for the livenessprobe container. ([#57](kubernetes-csi/livenessprobe#57), [@stefansedich](https://github.com/stefansedich)) - Deprecated "--connection-timeout" argument has been removed. ([#59](kubernetes-csi/livenessprobe#59), [@msau42](https://github.com/msau42)) - Fix nil pointer bug when driver responds with not ready ([#58](kubernetes-csi/livenessprobe#58), [@scuzhanglei](https://github.com/scuzhanglei)) - Migrated to Go modules, so the source builds also outside of GOPATH. ([#53](kubernetes-csi/livenessprobe#53), [@pohly](https://github.com/pohly))

@davidz627

All external-provisioner versions < 1.4.0 are deprecated and will stop functioning in Kubernetes v1.20. See [#323](kubernetes-csi/external-provisioner#323) and [k/k#80978](kubernetes/kubernetes#80978) for more details. Upgrade your external-provisioner to v1.4+ before Kubernetes v1.20. None - Fixes migration scenarios for Topology, fstype, and accessmodes for the kubernetes.io/gce-pd in-tree plugin ([#277](kubernetes-csi/external-provisioner#277), [@davidz627](https://github.com/davidz627)) - Checks if volume content source is populated if creating a volume from a snapshot source. ([#283](kubernetes-csi/external-provisioner#283), [@zhucan](https://github.com/zhucan)) - Fixes issue when SelfLink removal is turned on in Kubernetes. ([#323](kubernetes-csi/external-provisioner#323), [@msau42](https://github.com/msau42)) - CSI driver can return `CreateVolumeResponse` with size 0, which means unknown volume size. In this case, Provisioner will use PVC requested size as PV size rather than 0 bytes ([#271](kubernetes-csi/external-provisioner#271), [@hoyho](https://github.com/hoyho)) - Fixed potential leak of volumes after CSI driver timeouts. ([#312](kubernetes-csi/external-provisioner#312), [@jsafrane](https://github.com/jsafrane)) - Fixes issue where provisioner provisions volumes for in-tree PVC's which have not been migrated ([#341](kubernetes-csi/external-provisioner#341), [@davidz627](https://github.com/davidz627)) - Send the CSI volume_id instead of PVC Name to the csi-driver in volumeCreate when datasource is PVC ([#310](kubernetes-csi/external-provisioner#310), [@Madhu-1](https://github.com/Madhu-1)) - Fixes nil pointer derefence in log when migration turned on ([#342](kubernetes-csi/external-provisioner#342), [@davidz627](https://github.com/davidz627)) - Handle deletion of CSI migrated volumes ([#273](kubernetes-csi/external-provisioner#273), [@ddebroy](https://github.com/ddebroy)) - Reduced logging noise of unrelated PVCs. Emit event on successful provisioning. ([#351](kubernetes-csi/external-provisioner#351), [@jsafrane](https://github.com/jsafrane)) - Added extra verification of source Snapshot and PersistentVolumeClaim before provisioning. ([#352](kubernetes-csi/external-provisioner#352), [@jsafrane](https://github.com/jsafrane))

@jsafrane

* Fixed handling of ControllerUnpublish errors. The attacher will retry to ControllerUnpublish a volume after any error except for NotFound. (#168, @jsafrane)

@xing-yang

Breaking Changes * Changes the API group name for the fake VolumeSnapshot object to "snapshot.storage.k8s.io" to be in-sync with the group name of the real VolumeSnapshot object. As a result, the generated interfaces for clientset and informers of VolumeSnapshot are also changed from "VolumeSnapshot" to "Snapshot". (#123, @xing-yang) New Features * Adds Finalizer on the snapshot source PVC to prevent it from being deleted when a snapshot is being created from it. (#47, @xing-yang) Other Notable Changes * Add Status subresource for VolumeSnapshot. (#121, @zhucan) * Cherry picks PR #138: Prebound snapshots will work correctly with CSI drivers that does not support ListSnasphots.(#156, @hakanmemisoglu) * Cherry picks PR #172: Added extra verification of source PersistentVolumeClaim before creating snapshot.(#173, @xing-yang)

@saad-ali

New Features * Add prometheus metrics to CSI external-resizer under the /metrics endpoint. This can be enabled via the "--metrics-address" and "--metrics-path" options. (#67, @saad-ali) Bug Fixes * Avoid concurrent processing of same PVCs (#6, @mlmhl) * Exit on CSI gRPC conn loss (#55, @ggriffiths) * Verify claimref associated with PVs before resizing (#57, @gnufied) Other Notable Changes * Migrated to Go modules, so the source builds also outside of GOPATH. (#60, @pohly)

dkoshkin · 2020-03-18T21:05:44Z

stable/awsebscsiprovisioner/Chart.yaml

@@ -1,12 +1,12 @@
 apiVersion: v1
-appVersion: "0.4.0"
+appVersion: "0.5.0"


Im seeing this in the test log https://teamcity.mesosphere.io/viewLog.html?buildId=2646542&buildTypeId=ClosedSource_Konvoy_ChartPr&tab=buildLog&_focus=847#_state=205

uh thanks @dkoshkin will recheck

Is this still relevant?

solved e2e ;) so not relevant anymore :)

- updated args as mentioned in comments - updated container versions as mentioned in the comments D2IQ-64990 #comment updated awsebscsiprovisioner pod arg

- added statefulSet.podAnnotations feature - added new roles and snapshotter-controller - added more values to be setable D2IQ-64992 #comment updated awsebscsiprovisioner to include statefulSet.podAnnotations

- this was added for being able to run the ct install / upgrade behaviour so that we also can test with that priorityClassName set pods, that normally get a system-node critial or system-cluster-critical priorityClassName set. These only will be allowed to run in namespace kube-system and that for we need to drop the priorityClassName here to null for our tests. - separated lint and install, as otherwise lint would fail because of the sed changes - exclude gcp-csi-driver [D2IQ-65765] [D2IQ-65765]: https://jira.d2iq.com/browse/D2IQ-65765

hectorj2f · 2020-03-19T12:44:29Z

stable/awsebscsiprovisioner/values.yaml

@@ -65,11 +97,15 @@ storageclass:
  reclaimPolicy: Delete
  volumeBindingMode: WaitForFirstConsumer
  type: gp2
+  fstype: ext4


is this the default value ext4 ?

jup
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/tree/v0.5.0#createvolume-parameters

shaneutt

This LGTM, but let's keep in mind that this version should be tested in MWT in our upcoming one

hectorj2f · 2020-03-19T14:08:40Z

@sebbrandt87 once this PR is merged open a test pr in kubernetes-base-addons && konvoy to validate these changes.

shaneutt · 2020-03-19T14:31:52Z

I would advise manual testing of the chart itself before merging, if none has been done yet. Better to not publish something that hasn't at least been proven to function or else we just publish a dead version. 🤔

KBA will only test this for basic validations, deployment, and cleanup. Not functionality of the app itself, but rather addon machinery.

sebbrandt87 · 2020-03-19T14:47:00Z

will run it on a cluster manually, but CI e2e showed already

all flags are correct (I even correct one that was wrong)
all pods are starting
all pods logs looks how they should look like

shaneutt · 2020-03-19T14:50:52Z

will run it on a cluster manually, but CI e2e showed already
* all flags are correct (I even correct one that was wrong)

* all pods are starting

* all pods logs looks how they should look like

sgtm, it's one of those better safe than sorry kind of situations

sebbrandt87 · 2020-03-19T14:51:32Z

sgtm, it's one of those better safe than sorry kind of situations

sure thing 😉

shaneutt · 2020-03-19T14:53:12Z

@mesosphere/sig-ksphere-cluster we need signoff from a member of your team please to proceed 🖖

@jieyu

…bs-csi-driver from 0.4.0 to 0.5.0 [Documentation](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/v0.5.0/docs/README.md) filename | sha512 hash --------- | ------------ [v0.5.0.zip](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/archive/v0.5.0.zip) | [v0.5.0.tar.gz](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/archive/v0.5.0.tar.gz) | * Add a cmdline option to add extra volume tags ([#353](kubernetes-sigs/aws-ebs-csi-driver#353), [@jieyu](https://github.com/jieyu)) * Switch to use kustomize for manifest ([#360](kubernetes-sigs/aws-ebs-csi-driver#360), [@leakingtapan](https://github.com/leakingtapan)) * enable users to set ec2-endpoint for nonstandard regions ([#369](kubernetes-sigs/aws-ebs-csi-driver#369), [@amdonov](https://github.com/amdonov)) * Add standard volume type ([#379](kubernetes-sigs/aws-ebs-csi-driver#379), [@leakingtapan](https://github.com/leakingtapan)) * Update aws sdk version to enable EKS IAM for SA ([#386](kubernetes-sigs/aws-ebs-csi-driver#386), [@leakingtapan](https://github.com/leakingtapan)) * Implement different driver modes and AWS Region override for controller service ([#438](kubernetes-sigs/aws-ebs-csi-driver#438), [@rfranzke](https://github.com/rfranzke)) * Add manifest files for snapshotter 2.0 ([#452](kubernetes-sigs/aws-ebs-csi-driver#452), [@leakingtapan](https://github.com/leakingtapan)) * Return success if instance or volume are not found ([#375](kubernetes-sigs/aws-ebs-csi-driver#375), [@bertinatto](https://github.com/bertinatto)) * Patch k8scsi sidecars CVE-2019-11255 ([#413](kubernetes-sigs/aws-ebs-csi-driver#413), [@jnaulty](https://github.com/jnaulty)) * Handle mount flags in NodeStageVolume ([#430](kubernetes-sigs/aws-ebs-csi-driver#430), [@bertinatto](https://github.com/bertinatto)) * Run upstream e2e test suites with migration ([#341](kubernetes-sigs/aws-ebs-csi-driver#341), [@wongma7](https://github.com/wongma7)) * Use new test framework for test orchestration ([#359](kubernetes-sigs/aws-ebs-csi-driver#359), [@leakingtapan](https://github.com/leakingtapan)) * Update to use 1.16 cluster with inline test enabled ([#362](kubernetes-sigs/aws-ebs-csi-driver#362), [@leakingtapan](https://github.com/leakingtapan)) * Enable leader election ([#380](kubernetes-sigs/aws-ebs-csi-driver#380), [@leakingtapan](https://github.com/leakingtapan)) * Update go mod and mount library ([#388](kubernetes-sigs/aws-ebs-csi-driver#388), [@leakingtapan](https://github.com/leakingtapan)) * Refactor NewCloud by pass in region ([#394](kubernetes-sigs/aws-ebs-csi-driver#394), [@leakingtapan](https://github.com/leakingtapan)) * helm: provide an option to set extra volume tags ([#396](kubernetes-sigs/aws-ebs-csi-driver#396), [@jieyu](https://github.com/jieyu)) * Allow override for csi-provisioner image ([#401](kubernetes-sigs/aws-ebs-csi-driver#401), [@gliptak](https://github.com/gliptak)) * Enable volume expansion e2e test for CSI migration ([#407](kubernetes-sigs/aws-ebs-csi-driver#407), [@leakingtapan](https://github.com/leakingtapan)) * Swith to use kops 1.16 ([#409](kubernetes-sigs/aws-ebs-csi-driver#409), [@leakingtapan](https://github.com/leakingtapan)) * Added tolerations for node support ([#420](kubernetes-sigs/aws-ebs-csi-driver#420), [@zerkms](https://github.com/zerkms)) * Update helm chart to better match available values and add the ability to add annotations ([#423](kubernetes-sigs/aws-ebs-csi-driver#423), [@krmichel](https://github.com/krmichel)) * [helm] Also add toleration support to controller ([#433](kubernetes-sigs/aws-ebs-csi-driver#433), [@jyaworski](https://github.com/jyaworski)) * Add ec2:ModifyVolume action ([#434](kubernetes-sigs/aws-ebs-csi-driver#434), [@zodiac12k](https://github.com/zodiac12k)) * Schedule the EBS CSI DaemonSet on all nodes by default ([#441](kubernetes-sigs/aws-ebs-csi-driver#441), [@pcfens](https://github.com/pcfens)) * bump chart version * chore: bump liveness probe from 1.1.0 to 2.0.0 - Introduce V(5) on the health check begin/success log lines to allow filtering of these entries from logs. If you would like to retain these log entries the action required would be to set or higher for the livenessprobe container. ([#57](kubernetes-csi/livenessprobe#57), [@stefansedich](https://github.com/stefansedich)) - Deprecated --connection-timeout argument has been removed. ([#59](kubernetes-csi/livenessprobe#59), [@msau42](https://github.com/msau42)) - Fix nil pointer bug when driver responds with not ready ([#58](kubernetes-csi/livenessprobe#58), [@scuzhanglei](https://github.com/scuzhanglei)) - Migrated to Go modules, so the source builds also outside of GOPATH. ([#53](kubernetes-csi/livenessprobe#53), [@pohly](https://github.com/pohly)) * chore: bump csi external-provisioner from 1.3.0 to 1.4.0 All external-provisioner versions < 1.4.0 are deprecated and will stop functioning in Kubernetes v1.20. See [#323](kubernetes-csi/external-provisioner#323) and [k/k#80978](kubernetes/kubernetes#80978) for more details. Upgrade your external-provisioner to v1.4+ before Kubernetes v1.20. None - Fixes migration scenarios for Topology, fstype, and accessmodes for the kubernetes.io/gce-pd in-tree plugin ([#277](kubernetes-csi/external-provisioner#277), [@davidz627](https://github.com/davidz627)) - Checks if volume content source is populated if creating a volume from a snapshot source. ([#283](kubernetes-csi/external-provisioner#283), [@zhucan](https://github.com/zhucan)) - Fixes issue when SelfLink removal is turned on in Kubernetes. ([#323](kubernetes-csi/external-provisioner#323), [@msau42](https://github.com/msau42)) - CSI driver can return with size 0, which means unknown volume size. In this case, Provisioner will use PVC requested size as PV size rather than 0 bytes ([#271](kubernetes-csi/external-provisioner#271), [@hoyho](https://github.com/hoyho)) - Fixed potential leak of volumes after CSI driver timeouts. ([#312](kubernetes-csi/external-provisioner#312), [@jsafrane](https://github.com/jsafrane)) - Fixes issue where provisioner provisions volumes for in-tree PVC's which have not been migrated ([#341](kubernetes-csi/external-provisioner#341), [@davidz627](https://github.com/davidz627)) - Send the CSI volume_id instead of PVC Name to the csi-driver in volumeCreate when datasource is PVC ([#310](kubernetes-csi/external-provisioner#310), [@Madhu-1](https://github.com/Madhu-1)) - Fixes nil pointer derefence in log when migration turned on ([#342](kubernetes-csi/external-provisioner#342), [@davidz627](https://github.com/davidz627)) - Handle deletion of CSI migrated volumes ([#273](kubernetes-csi/external-provisioner#273), [@ddebroy](https://github.com/ddebroy)) - Reduced logging noise of unrelated PVCs. Emit event on successful provisioning. ([#351](kubernetes-csi/external-provisioner#351), [@jsafrane](https://github.com/jsafrane)) - Added extra verification of source Snapshot and PersistentVolumeClaim before provisioning. ([#352](kubernetes-csi/external-provisioner#352), [@jsafrane](https://github.com/jsafrane)) * chore: bump attacher * Fixed handling of ControllerUnpublish errors. The attacher will retry to ControllerUnpublish a volume after any error except for NotFound. (#168, @jsafrane) * bump external-snapshotter from 1.1.0 to 1.2.2 Breaking Changes * Changes the API group name for the fake VolumeSnapshot object to snapshot.storage.k8s.io to be in-sync with the group name of the real VolumeSnapshot object. As a result, the generated interfaces for clientset and informers of VolumeSnapshot are also changed from VolumeSnapshot to Snapshot. (#123, @xing-yang) New Features * Adds Finalizer on the snapshot source PVC to prevent it from being deleted when a snapshot is being created from it. (#47, @xing-yang) Other Notable Changes * Add Status subresource for VolumeSnapshot. (#121, @zhucan) * Cherry picks PR #138: Prebound snapshots will work correctly with CSI drivers that does not support ListSnasphots.(#156, @hakanmemisoglu) * Cherry picks PR #172: Added extra verification of source PersistentVolumeClaim before creating snapshot.(#173, @xing-yang) * bump external-resizer from 0.2.0 to 0.4.0 New Features * Add prometheus metrics to CSI external-resizer under the /metrics endpoint. This can be enabled via the --metrics-address and --metrics-path options. (#67, @saad-ali) Bug Fixes * Avoid concurrent processing of same PVCs (#6, @mlmhl) * Exit on CSI gRPC conn loss (#55, @ggriffiths) * Verify claimref associated with PVs before resizing (#57, @gnufied) Other Notable Changes * Migrated to Go modules, so the source builds also outside of GOPATH. (#60, @pohly) * feat(awsebscsiprovisioner): updated awsebscsiprovisioner flags - updated args as mentioned in comments - updated container versions as mentioned in the comments D2IQ-64990 #comment updated awsebscsiprovisioner pod arg * feat(awsebscsiprovisioner): added podAnnotations - added statefulSet.podAnnotations feature - added new roles and snapshotter-controller - added more values to be setable D2IQ-64992 #comment updated awsebscsiprovisioner to include statefulSet.podAnnotations * fix: added replacing system-x-critial replacement - this was added for being able to run the ct install / upgrade behaviour so that we also can test with that priorityClassName set pods, that normally get a system-node critial or system-cluster-critical priorityClassName set. These only will be allowed to run in namespace kube-system and that for we need to drop the priorityClassName here to null for our tests. - separated lint and install, as otherwise lint would fail because of the sed changes - exclude gcp-csi-driver [D2IQ-65765] [D2IQ-65765]: https://jira.d2iq.com/browse/D2IQ-65765 Co-authored-by: Sebastian Brandt <[email protected]>

makkes · 2020-03-19T14:51:16Z

stable/awsebscsiprovisioner/Chart.yaml

@@ -1,12 +1,12 @@
 apiVersion: v1
-appVersion: "0.4.0"
+appVersion: "0.5.0"


Is this still relevant?

stable/awsebscsiprovisioner/ci/more-specific-settings.yaml

joejulian added the wip label Mar 6, 2020

joejulian requested a review from a team as a code owner March 6, 2020 04:42

joejulian self-assigned this Mar 6, 2020

joejulian changed the title ~~chore: update aws-ebs-csi-driver from 0.4.0 to 0.5.0~~ chore: update awsebscsiprovisioner chart Mar 6, 2020

makkes previously approved these changes Mar 9, 2020

View reviewed changes

joejulian dismissed makkes’s stale review via a444b0a March 9, 2020 21:38

joejulian force-pushed the joe/awsebscsiprovisioner branch from f40f2ef to a444b0a Compare March 9, 2020 21:38

sebbrandt87 self-requested a review March 14, 2020 15:55

sebbrandt87 requested a review from a team as a code owner March 14, 2020 15:59

hectorj2f reviewed Mar 16, 2020

View reviewed changes

sebbrandt87 suggested changes Mar 16, 2020

View reviewed changes

stable/awsebscsiprovisioner/values.yaml Outdated Show resolved Hide resolved

sebbrandt87 force-pushed the joe/awsebscsiprovisioner branch from f439f94 to 6dddefe Compare March 18, 2020 14:27

joejulian added 7 commits March 18, 2020 15:28

bump chart version

28d316d

chore: bump attacher

c183581

* Fixed handling of ControllerUnpublish errors. The attacher will retry to ControllerUnpublish a volume after any error except for NotFound. (#168, @jsafrane)

sebbrandt87 force-pushed the joe/awsebscsiprovisioner branch from 6dddefe to 1f37aff Compare March 18, 2020 14:28

sebbrandt87 requested review from sebbrandt87 and makkes March 18, 2020 14:32

sebbrandt87 previously approved these changes Mar 18, 2020

View reviewed changes

dkoshkin reviewed Mar 18, 2020

View reviewed changes

sebbrandt87 dismissed stale reviews from geekbass and themself via de07912 March 18, 2020 22:08

sebbrandt87 force-pushed the joe/awsebscsiprovisioner branch 2 times, most recently from b733ae6 to 5265e53 Compare March 19, 2020 10:10

sebbrandt87 added 2 commits March 19, 2020 11:46

feat(awsebscsiprovisioner): updated awsebscsiprovisioner flags

8b2cf7d

- updated args as mentioned in comments - updated container versions as mentioned in the comments D2IQ-64990 #comment updated awsebscsiprovisioner pod arg

feat(awsebscsiprovisioner): added podAnnotations

6fa3165

- added statefulSet.podAnnotations feature - added new roles and snapshotter-controller - added more values to be setable D2IQ-64992 #comment updated awsebscsiprovisioner to include statefulSet.podAnnotations

sebbrandt87 force-pushed the joe/awsebscsiprovisioner branch 2 times, most recently from 1be209b to d7fbd5c Compare March 19, 2020 11:01

sebbrandt87 force-pushed the joe/awsebscsiprovisioner branch from d7fbd5c to b1178b8 Compare March 19, 2020 11:45

sebbrandt87 requested review from dkoshkin, geekbass and sebbrandt87 March 19, 2020 12:16

sebbrandt87 approved these changes Mar 19, 2020

View reviewed changes

hectorj2f reviewed Mar 19, 2020

View reviewed changes

shaneutt approved these changes Mar 19, 2020

View reviewed changes

shaneutt requested a review from hectorj2f March 19, 2020 13:54

hectorj2f approved these changes Mar 19, 2020

View reviewed changes

hectorj2f merged commit b6e53ee into master Mar 19, 2020

hectorj2f deleted the joe/awsebscsiprovisioner branch March 19, 2020 14:53

makkes reviewed Mar 19, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update awsebscsiprovisioner chart #492

chore: update awsebscsiprovisioner chart #492

joejulian commented Mar 6, 2020 •

edited

Loading

jieyu commented Mar 6, 2020

makkes commented Mar 9, 2020

joejulian commented Mar 9, 2020

sebbrandt87 commented Mar 14, 2020

hectorj2f left a comment

sebbrandt87 Mar 16, 2020

sebbrandt87 commented Mar 16, 2020 •

edited

Loading

sebbrandt87 commented Mar 16, 2020 •

edited

Loading

sebbrandt87 commented Mar 17, 2020

dkoshkin Mar 18, 2020

sebbrandt87 Mar 18, 2020

makkes Mar 19, 2020

sebbrandt87 Mar 19, 2020

hectorj2f Mar 19, 2020

sebbrandt87 Mar 19, 2020 •

edited

Loading

shaneutt left a comment

hectorj2f commented Mar 19, 2020

shaneutt commented Mar 19, 2020 •

edited

Loading

sebbrandt87 commented Mar 19, 2020

shaneutt commented Mar 19, 2020

sebbrandt87 commented Mar 19, 2020

shaneutt commented Mar 19, 2020

makkes Mar 19, 2020

chore: update awsebscsiprovisioner chart #492

chore: update awsebscsiprovisioner chart #492

Conversation

joejulian commented Mar 6, 2020 • edited Loading

Bump aws-ebs-csi-driver from 0.4.0 to 0.5.0

bump livenessprobe from 1.1.0 to 2.0.0

Changes since v1.1.0

Action Required

Other Notable Changes

bump csi external-provisioner from 1.3.0 to 1.4.0

Changelog since v1.3.0

Deprecations

New Features

Bug Fixes

bump csi external-attacher from 1.2.0 to 1.2.1

Bug Fixes

bump external-snapshotter from 1.1.0 to 1.2.2

Breaking Changes

New Features

Other Notable Changes

bump external-resizer from 0.2.0 to 0.4.0

New Features

Bug Fixes

Other Notable Changes

jieyu commented Mar 6, 2020

makkes commented Mar 9, 2020

joejulian commented Mar 9, 2020

sebbrandt87 commented Mar 14, 2020

hectorj2f left a comment

Choose a reason for hiding this comment

sebbrandt87 Mar 16, 2020

Choose a reason for hiding this comment

sebbrandt87 commented Mar 16, 2020 • edited Loading

sebbrandt87 commented Mar 16, 2020 • edited Loading

sebbrandt87 commented Mar 17, 2020

dkoshkin Mar 18, 2020

Choose a reason for hiding this comment

sebbrandt87 Mar 18, 2020

Choose a reason for hiding this comment

makkes Mar 19, 2020

Choose a reason for hiding this comment

sebbrandt87 Mar 19, 2020

Choose a reason for hiding this comment

hectorj2f Mar 19, 2020

Choose a reason for hiding this comment

sebbrandt87 Mar 19, 2020 • edited Loading

Choose a reason for hiding this comment

shaneutt left a comment

Choose a reason for hiding this comment

hectorj2f commented Mar 19, 2020

shaneutt commented Mar 19, 2020 • edited Loading

sebbrandt87 commented Mar 19, 2020

shaneutt commented Mar 19, 2020

sebbrandt87 commented Mar 19, 2020

shaneutt commented Mar 19, 2020

makkes Mar 19, 2020

Choose a reason for hiding this comment

joejulian commented Mar 6, 2020 •

edited

Loading

sebbrandt87 commented Mar 16, 2020 •

edited

Loading

sebbrandt87 commented Mar 16, 2020 •

edited

Loading

sebbrandt87 Mar 19, 2020 •

edited

Loading

shaneutt commented Mar 19, 2020 •

edited

Loading