Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added padding to the video image #237

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Conversation

sonalgaud12
Copy link
Contributor

@sonalgaud12 sonalgaud12 commented Dec 21, 2024

Notes for Reviewers

This PR fixes #233

image

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Dec 21, 2024

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit c098a75
🔍 Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/67668a64a125aa0008e27b35
😎 Deploy Preview https://deploy-preview-237--meshery-play.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -213,7 +213,10 @@ export const Main = styled.main`
section.video {
margin: 4rem auto;
display: flex;
-webkit-box-pack: center;
Copy link

@Ajay-singh1 Ajay-singh1 Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-webkit-box-pack: center;

This is not needed remove this else everything looks good.

Copy link

@Ajay-singh1 Ajay-singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!Approved.Thanks @sonalgaud12

@sonalgaud12
Copy link
Contributor Author

@leecalcote Requesting your review

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sonalgaud12 👍

@leecalcote leecalcote merged commit b8f2c20 into meshery:master Jan 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Issue: Padding around the image in the Meshery Playground wesbite is incorrect.
3 participants