Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Issue: Padding around the image in the Meshery Playground wesbite is incorrect. #233

Closed
sonalgaud12 opened this issue Dec 20, 2024 · 3 comments · Fixed by #237
Closed
Assignees
Labels
kind/bug Something isn't working

Comments

@sonalgaud12
Copy link
Contributor

Current Behavior

The image in the Playground website is cutting off the logo due to insufficient padding.

Expected Behavior

Add padding on the section.video class

Screenshots/Logs

image

Environment

  • Host OS: Mac Linux Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v

Contributor Guides and Resources

@Ajay-singh1
Copy link

Ajay-singh1 commented Dec 21, 2024

Hello , @sonalgaud12 Thanks for this PR but I feel their are too many changes which is not necessary so remove the unnecessary code.

@sonalgaud12
Copy link
Contributor Author

Hii @Ajay-singh1 Thank you for working on the issue, i did raise a pr with clean files. I did request a review Let wait for the reviewer to check our prs.

@Ajay-singh1
Copy link

Hii @Ajay-singh1 Thank you for working on the issue, i did raise a pr with clean files. I did request a review Let wait for the reviewer to check our prs.

It looks good now I have reviewed it wait for the project maintainer to merge it now.Good job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment