Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/shashank kavli/158# #159

Closed
wants to merge 5 commits into from
Closed

Bug/shashank kavli/158# #159

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72734e7
[UX] Theme Toggle icon Fix
shashank-kavli Sep 26, 2023
f242a09
[UX] Theme Toggle icon Fix
shashank-kavli Sep 26, 2023
d49ea2b
[UI] Theme Toggle
shashank-kavli Sep 28, 2023
4707f59
[UI] Theme Toggle
shashank-kavli Sep 28, 2023
7d041f8
Merge branch 'master' into bug/shashank-kavli/158#
shashank-kavli Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions site/src/components/Navigation/Navigation.styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ export const Header = styled.header`
padding: 10px 0;
display: flex;
justify-content: center;
align-items:center;
border-radius:20px;
border: 1px solid gray
align-items:center
// border-radius:20px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// border-radius:20px;

// border: 1px solid gray
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// border: 1px solid gray

}
.btn-container{
display: none;
Expand Down Expand Up @@ -213,4 +213,4 @@ export const Header = styled.header`
}
`

export default Header;
export default Header;
7 changes: 4 additions & 3 deletions site/src/components/Navigation/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ function Navigation({theme, toggleTheme, showSignUpButton}) {
{/* <a href="https://playground.meshery.io" className="login-btn" role="button">Login</a> */}
</div>
<div className="dropdown_btn" onClick={handleNavOpen}>
<Toggle theme={theme} toggleTheme={toggleTheme} />
{openNav ?
(<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" strokeWidth={1.5} stroke="currentColor" className="hamburger-icon">
<path strokeLinecap="round" strokeLinejoin="round" d="M6 18L18 6M6 6l12 12" />
Expand All @@ -43,9 +44,9 @@ function Navigation({theme, toggleTheme, showSignUpButton}) {
</div>
</nav>
<div className={openNav ? "dropdown_menu_opened" : "dropdown_menu_closed"}>
<div className="mode-btn">
{/* <div className="mode-btn">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{/* <div className="mode-btn">

<Toggle theme={theme} toggleTheme={toggleTheme} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Toggle theme={theme} toggleTheme={toggleTheme} />

</div>
</div> */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</div> */}

<div className="action-btns">
<a href="#signup-form" className="signup-btn" role="button">Sign Up</a>
{/* <a href="https://demo.meshery.io" className="login-btn" role="button">Login</a> */}
Expand All @@ -55,4 +56,4 @@ function Navigation({theme, toggleTheme, showSignUpButton}) {
)
}

export default Navigation
export default Navigation