Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/shashank kavli/158# #159

Closed

Conversation

shashank-kavli
Copy link

@shashank-kavli shashank-kavli commented Sep 26, 2023

Notes for Reviewers

This PR fixes #158

Signed commits

  • Yes, I signed my commits.

Signed-off-by: shashank-kavli <[email protected]>
Signed-off-by: shashank-kavli <[email protected]>
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit 7d041f8
🔍 Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/6515b38ac94fbb00086e5edf
😎 Deploy Preview https://deploy-preview-159--meshery-play.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shashank-kavli
Copy link
Author

@goldfishdolphin Pls check and lmk if any changes are required. Hoping that I've raised the PR correctly 🤞

@goldfishdolphin
Copy link
Member

Looking good 👍🏽

border-radius:20px;
border: 1px solid gray
align-items:center
// border-radius:20px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// border-radius:20px;

border: 1px solid gray
align-items:center
// border-radius:20px;
// border: 1px solid gray
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// border: 1px solid gray

@@ -43,9 +44,9 @@ function Navigation({theme, toggleTheme, showSignUpButton}) {
</div>
</nav>
<div className={openNav ? "dropdown_menu_opened" : "dropdown_menu_closed"}>
<div className="mode-btn">
{/* <div className="mode-btn">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{/* <div className="mode-btn">

@@ -43,9 +44,9 @@ function Navigation({theme, toggleTheme, showSignUpButton}) {
</div>
</nav>
<div className={openNav ? "dropdown_menu_opened" : "dropdown_menu_closed"}>
<div className="mode-btn">
{/* <div className="mode-btn">
<Toggle theme={theme} toggleTheme={toggleTheme} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Toggle theme={theme} toggleTheme={toggleTheme} />

<Toggle theme={theme} toggleTheme={toggleTheme} />
</div>
</div> */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</div> */}

@goldfishdolphin
Copy link
Member

Please remove the commented code. Otherwise all good 👍🏽

@shashank-kavli
Copy link
Author

@goldfishdolphin I've made the requested changes

Copy link
Member

@goldfishdolphin goldfishdolphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shashank-kavli for your great work .

@saurabh100ni
Copy link

Let's discuss this Item in tomorrow's website call,
please add it as your agenda if you would:
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit

Copy link

stale bot commented Nov 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 13, 2023
Copy link

stale bot commented Nov 23, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Theme Toggle icon
3 participants