-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/shashank kavli/158# #159
Bug/shashank kavli/158# #159
Conversation
Signed-off-by: shashank-kavli <[email protected]>
Signed-off-by: shashank-kavli <[email protected]>
✅ Deploy Preview for meshery-play ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@goldfishdolphin Pls check and lmk if any changes are required. Hoping that I've raised the PR correctly 🤞 |
Looking good 👍🏽 |
border-radius:20px; | ||
border: 1px solid gray | ||
align-items:center | ||
// border-radius:20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// border-radius:20px; | |
border: 1px solid gray | ||
align-items:center | ||
// border-radius:20px; | ||
// border: 1px solid gray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// border: 1px solid gray | |
@@ -43,9 +44,9 @@ function Navigation({theme, toggleTheme, showSignUpButton}) { | |||
</div> | |||
</nav> | |||
<div className={openNav ? "dropdown_menu_opened" : "dropdown_menu_closed"}> | |||
<div className="mode-btn"> | |||
{/* <div className="mode-btn"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{/* <div className="mode-btn"> |
@@ -43,9 +44,9 @@ function Navigation({theme, toggleTheme, showSignUpButton}) { | |||
</div> | |||
</nav> | |||
<div className={openNav ? "dropdown_menu_opened" : "dropdown_menu_closed"}> | |||
<div className="mode-btn"> | |||
{/* <div className="mode-btn"> | |||
<Toggle theme={theme} toggleTheme={toggleTheme} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Toggle theme={theme} toggleTheme={toggleTheme} /> | |
<Toggle theme={theme} toggleTheme={toggleTheme} /> | ||
</div> | ||
</div> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</div> */} | |
Please remove the commented code. Otherwise all good 👍🏽 |
Signed-off-by: shashank-kavli <[email protected]>
Signed-off-by: shashank-kavli <[email protected]>
@goldfishdolphin I've made the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shashank-kavli for your great work .
Let's discuss this Item in tomorrow's website call, |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Notes for Reviewers
This PR fixes #158
Signed commits