-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add validation of preventing signing up from anonymous mail domains #125
feat: Add validation of preventing signing up from anonymous mail domains #125
Conversation
…ains Signed-off-by: Kartik Jolapara <[email protected]>
❌ Deploy Preview for meshery-play failed.
|
Signed-off-by: Lee Calcote <[email protected]>
@codingmickey will you confirm that mutli-word first and last names, whether with whitespace or hyphenations is allowed? |
I'm removing other reviewers, who have yet to offer feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codingmickey thanks for this. Will you please address the other concern regarding multi-word names?
Will you ensure that the layer5.io forms follow this same approach?
@codingmickey Build failure:
|
Sure I can work upon that..
Aye aye |
Oops these didn't occur on my local, sorry about it.. will update and make a new pr |
@codingmickey will you consider an update to support this special character issue in the registration forms? - ā |
Notes for Reviewers
Blocking signing up from the following domains:
The list can be expanded in the future by just adding more domains in this regex
https://github.com/codingmickey/play/blob/e809dcefef7a10c3d3c7e93f473d78e0be3a310a/site/src/components/SignupForm/index.js#L19
This PR fixes #123
If any changes are required do let me know!
Signed commits