Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent signup using anonymous mail domains #123

Closed
leecalcote opened this issue Jul 6, 2023 · 4 comments · Fixed by #125
Closed

Prevent signup using anonymous mail domains #123

leecalcote opened this issue Jul 6, 2023 · 4 comments · Fixed by #125
Assignees
Labels
help wanted Extra attention is needed kind/enhancement Improvement in current feature language/javascript Javascript related

Comments

@leecalcote
Copy link
Member

Current Behavior

Anyone can signup to use the Meshery Playground. Signup is necessary to ensure accountability given the open cluster nature of the playground.

Desired Behavior

Disallow signups from the following domains:

  • @duck.com
  • @anonaddy.me
  • @protonmail.com
  • @tuta.io

Implementation

Field validation using javascript and regex.

Acceptance Tests

  1. Users who signup with any of the domains listed above are not allowed to submit the form.
  2. Users who signup with any of the domains listed above are shown the following message:

"Use of the is not allowed. Please use a non-anonymous email address / domain.

The Meshery Playground is connected to live Kubernetes cluster(s) and allows users full-control over those clusters. Requiring users to register a non-anonymous user account keeps the Playground safe and healthy for all to enjoy. Without requiring users to sign-in, the Meshery Playground would allow anonymous access for anyone and everyone to potentially perform nefarious acts. Sign-up to receive a user account, entitled with perpetually free and full access the Playground environment."


Contributor Guide

@leecalcote leecalcote added help wanted Extra attention is needed kind/enhancement Improvement in current feature language/javascript Javascript related labels Jul 6, 2023
@leecalcote leecalcote changed the title Prevent anonymous mail domains Prevent signup using anonymous mail domains Jul 6, 2023
@codingmickey
Copy link
Contributor

codingmickey commented Jul 9, 2023

Hi @leecalcote, I would like to work on this! Should I start with it?

@leecalcote
Copy link
Member Author

Sounds good, @codingmickey

@codingmickey
Copy link
Contributor

Hi, @leecalcote how should the given message be displayed according to you?

  • A modal including that message
  • Below the form inputs in red
  • or any other way that is better for the user to understand and has good UX

@leecalcote
Copy link
Member Author

leecalcote commented Jul 10, 2023

Thanks for asking. I'm in favor of the method in your second bullet point, which includes disabling (or keeping disabled) the Submit button until each field's criteria is satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/enhancement Improvement in current feature language/javascript Javascript related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants