Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Logo of Layer5 with Meshery in config.yml workflow #93

Closed
anshgoyalevil opened this issue Apr 12, 2023 · 6 comments · Fixed by #101
Closed

Replace the Logo of Layer5 with Meshery in config.yml workflow #93

anshgoyalevil opened this issue Apr 12, 2023 · 6 comments · Fixed by #101
Assignees
Labels
area/ci Continuous integration | Build and release

Comments

@anshgoyalevil
Copy link
Member

anshgoyalevil commented Apr 12, 2023

Description

Currently, we are using the Logo of Layer5 instead of Meshery. This repository is under the organization Meshery, so, there should be the image of Meshery.

How to resolve this?

  • Go to .github and replace this welcome image with the new one:

  • Make sure to display the images conditionally, based on the theme selected by user.
    Here's the sample code:

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Meshery Logo" src="">
</picture>

New images are:

Meshery-celebration-Light
Meshery-celebration-Dark

  • Download these images, and upload with an appropriate name. Make sure to use conditional rendering as described above.

  • After uploading the image, and removing the previous image, go to .github/config.yml folder and update the reference to previous image to the new image in the following part:

firstPRMergeComment: >
  Thanks for your contribution to the Layer5 and Meshery community! :tada:
   
  ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png)
  &nbsp; &#9; &nbsp; &#9;  &nbsp; &#9;  &nbsp; &#9; :star: Please leave a [star on the project](../stargazers). :smile:

Here, replace ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png) with the code

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Shows a black logo in light color mode and a white one in dark color mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
</picture>

make sure to change the image sources with the path to image in the folder where you upload it.

  • That's it.

Contributor Guides and Handbook

@anshgoyalevil anshgoyalevil added the area/ci Continuous integration | Build and release label Apr 12, 2023
@Saksham294
Copy link

Hey can I work on this?

@leecalcote
Copy link
Member

@anshgoyalevil, never store images like this outside of the repo. They must be stored inside of .github. @goldfishdolphin help, help.

@anshgoyalevil
Copy link
Member Author

@leecalcote

Actually, I was previously testing this Raw SVG thing, so used the same srcset instead of images stored inside the repo.

Made a PR fixing that thing. Apologies.

@vishalvivekm
Copy link
Contributor

@anshgoyalevil // @goldfishdolphin
Guys, some of the points that you should take special care of while changing the logos in the readme or the workflows:

  1. all images for the readme/workflow-logos should be under .github somewhere, not in other repos or in other folders in the same repo.
  2. make sure they support both dark mode and light mode
  3. Please also ensure correct image size and margins around them i.e, there' shouldn't be this much spacing that's there in the meshery/meshery-nginx-sm Readme.md
    // Fix logos meshery-nginx-sm#224

@anshgoyalevil
Copy link
Member Author

@vishalvivekm

Thanks for giving the suggestions Sir. Will keep them in mind for future.

@ankur0904
Copy link
Contributor

Can I work on this issue?

leecalcote added a commit that referenced this issue Apr 26, 2023
Replaces the Logo of Layer5 with given Meshery svg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants