Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logos #224

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Fix logos #224

merged 3 commits into from
Apr 14, 2023

Conversation

goldfishdolphin
Copy link
Member

Description

This PR fixes #7491 in meshery [Docs] Replace old Meshery logos

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@welcome
Copy link

welcome bot commented Apr 14, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @goldfishdolphin 👏

@leecalcote leecalcote merged commit 4bc3910 into meshery:master Apr 14, 2023
@welcome
Copy link

welcome bot commented Apr 14, 2023

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

@goldfishdolphin goldfishdolphin deleted the fix-logos branch April 14, 2023 22:03
@vishalvivekm
Copy link
Contributor

@goldfishdolphin would you mind sharing how the Readme.md looks like after your changes were merged
for me I see the logos to be broken:
Screenshot 2023-04-18 013823

@goldfishdolphin
Copy link
Member Author

@vishalvivekm that is very strange as it is locally it is like this.
Screenshot 2023-04-18 at 11 08 47 am

Screenshot 2023-04-18 at 11 08 07 am

@goldfishdolphin goldfishdolphin restored the fix-logos branch April 18, 2023 10:19
@vishalvivekm
Copy link
Contributor

vishalvivekm commented Apr 18, 2023

Sorry, due to some internet issues, the logos in the readme weren't being rendered, it's working well now, here's how it looks like after your changes
Screenshot from 2023-04-18 16-55-03

Here's some feedback :

  1. there's too much spacing between the first logo and the header "Meshery Adapter for NGINX Service Mesh"
  2. the second meshery logo, the size is quite not what it should be: isn't it so small? and the margins around it: much spacing
    Screenshot from 2023-04-18 17-11-37

@goldfishdolphin

@goldfishdolphin
Copy link
Member Author

@vishalvivekm I agree with you. But it is still not appearing on browser as on vs code. Apparently img tag is not rendering dark/light mode images that I replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants