-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logos #224
Fix logos #224
Conversation
Signed-off-by: Naureen <[email protected]>
Signed-off-by: Naureen <[email protected]>
Signed-off-by: Naureen <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @goldfishdolphin 👏
@goldfishdolphin would you mind sharing how the Readme.md looks like after your changes were merged |
@vishalvivekm that is very strange as it is locally it is like this. |
Sorry, due to some internet issues, the logos in the readme weren't being rendered, it's working well now, here's how it looks like after your changes Here's some feedback : |
@vishalvivekm I agree with you. But it is still not appearing on browser as on vs code. Apparently img tag is not rendering dark/light mode images that I replaced. |
Description
This PR fixes #7491 in meshery [Docs] Replace old Meshery logos
Notes for Reviewers
Signed commits