Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog] Use light/dark snapshot version #1593

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

aabidsofi19
Copy link
Member

Description

This PR fixes #
Use the version of snapshot based on theme

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Jan 21, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 22f10ff
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/65b75dc352f538000812b339
😎 Deploy Preview https://deploy-preview-1593--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Gemfile.lock Outdated Show resolved Hide resolved
@aabidsofi19
Copy link
Member Author

@leecalcote

@leecalcote
Copy link
Member

Ready to go?

@sudhanshutech
Copy link
Member

@aabidsofi19 merge conflicts...
Please remove the changes in gemfile(it will override the ruby configs) and .jekyll-metadata

Gemfile.lock Outdated Show resolved Hide resolved
@sudhanshutech
Copy link
Member

oops, seems like screenshot are not visible in front page but it is inside the modal. Will you confirm @aabidsofi19 ?
image

@aabidsofi19 aabidsofi19 requested a review from MUzairS15 January 29, 2024 16:17
@aabidsofi19
Copy link
Member Author

@MUzairS15 if you would confirm here

@MUzairS15 MUzairS15 merged commit a19bb80 into meshery:master Jan 31, 2024
7 checks passed
Copy link

welcome bot commented Jan 31, 2024

Thanks for your contribution to the Layer5 and Meshery community! 🎉

Meshery Logo
        ⭐ Please leave a star on the project. 😄

@leecalcote
Copy link
Member

Whee! @aabidsofi19 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants