-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Snapshots to Cypress native screenshots #74
Conversation
Signed-off-by: aabidsofi19 <[email protected]>
Since this is a filename, we will actually lowercase meshmap. Also, I prefer that we don’t use this name understanding that it may change. |
There are two different types of snapshots right now, stored in two different folders… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have opened a PR in the provider to support dark and light mode screenshots.
We require to verify this, when the screenshots are being generated for all cases
- Catalog snapshots
- Snapshots on PRs
we will require to update theadd_catalog
workflow and the logic inmeshery.io
.
@leecalcote in the same folder : |
It would be good to walk through this change on tomorrow's meeting, @aabidsofi19. @RipulHandoo, you might like to join that meeting. |
@leecalcote Sir. I'd love to join the meeting tomorrow, but as per my understanding and the community calendar, our next meeting is scheduled for Monday, 8th Jan 2024. Please let me know if there's any change or if you meant a different meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you please ensure that these e2e tests don't fail. https://github.com/layer5labs/meshmap-snapshot/actions/runs/7397423535/job/20124507958?pr=74
Since you have updated the download location so please consider updating the tests accordingly. if required 👍
https://github.com/layer5labs/meshmap-snapshot/blob/master/.github/workflows/file-path-build-test.yml
https://github.com/layer5labs/meshmap-snapshot/blob/master/.github/workflows/url-upload-test.yml
Or update the action.yml to look in the new directory.
Signed-off-by: MUzairS15 <[email protected]>
Signed-off-by: aabidsofi19 <[email protected]>
Updated the meshery cloud and meshery.io catalogs : |
Signed-off-by: MUzairS15 <[email protected]>
Signed-off-by: MUzairS15 <[email protected]>
Notes for Reviewers
This PR fixes
This pr migrates the snapshot service to use cypress's screenshoting feature .
reason :
// Notes for maintainers :