Describe contains coordinate not on the variable #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaudjester
changed the base branch from
main
to
copernicusmarine-toolbox-v2
|
should we add any tests to it? |
uriii3
reviewed
Sep 13, 2024
| @@ -236,6 +236,7 @@ def from_metadata_item( | |||
| metadata_item.properties.get("admp_valid_start_date"), | |||
| ) | |||
| for dimension, dimension_metadata in dimensions.items() | |||
| if variable_id in dimension_metadata.get("chunkLen", {}) | |||
There was a problem hiding this comment.
but the cube:variables is being called right up from this line, no? in line 220. Should the information be there? If not, I'm also fine with using the chunkLen option although seems less intuitive when rereading the code.
renaudjester
force-pushed
the
describe-contains-coordinate-not-on-the-variable
branch
from
322e66b to
af05b9b
Compare
renaudjester
commented
Sep 13, 2024
There was a problem hiding this comment.
Maybe it's a big file but I feel like it's nice to have a snapshot of some dataset so we could see some changes @uriii3
uriii3
approved these changes
Sep 17, 2024
renaudjester
force-pushed
the
describe-contains-coordinate-not-on-the-variable
branch
from
28cca30 to
1214b3e
Compare
renaudjester
deleted the
describe-contains-coordinate-not-on-the-variable
branch
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
Fix a bug where we would have some coordinates for variables that don't have it in the describe
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
Fix a bug where we would have some coordinates for variables that don't have it in the describe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: CMT-103
Uses the fact that if the coordinate is not in the chunkLen dict then it means that the variable doesn't have the coordinate
I think the real information is in cube:variables: but I don't want to move around a property
See https://stac.marine.copernicus.eu/metadata/GLOBAL_MULTIYEAR_PHY_ENS_001_031/cmems_mod_glo_phy-all_my_0.25deg_P1D-m_202311/dataset.stac.json for reference