Describe contains coordinate not on the variable (#131)

Fix a bug where we would have some coordinates for variables that don't have it in the describe

Makefile

@@ -90,3 +90,7 @@ build-and-publish-dockerhub-image:
 	docker build --ulimit nofile=65536:65536 --tag copernicusmarine/copernicusmarine:$${VERSION} --tag copernicusmarine/copernicusmarine:latest -f Dockerfile.dockerhub --build-arg VERSION="$${VERSION}" .
 	docker push copernicusmarine/copernicusmarine:$${VERSION}
 	docker push copernicusmarine/copernicusmarine:latest
+
+
+update-snapshots-tests:
+	pytest --snapshot-update tests/test_command_line_interface.py::TestCommandLineInterface::test_describe_including_datasets

copernicusmarine/catalogue_parser/models.py

@@ -220,7 +220,6 @@ def from_metadata_item(
         cube_variables = metadata_item.properties["cube:variables"]
         cube_variable = cube_variables[variable_id]
 
-        # to get coordinates
         extra_fields_asset = asset.extra_fields
         dimensions = extra_fields_asset.get("viewDims") or {}
         return cls(
@@ -236,6 +235,7 @@ def from_metadata_item(
                     metadata_item.properties.get("admp_valid_start_date"),
                 )
                 for dimension, dimension_metadata in dimensions.items()
+                if dimension in cube_variable["dimensions"]
             ],
         )
 

copernicusmarine/download_functions/utils.py

@@ -261,6 +261,9 @@ def get_approximation_size_data_downloaded(
     download_estimated_size = 0
     for variable_name in temp_dataset.data_vars:
         coordinates_size = 1
+        variable = [
+            var for var in service.variables if var.short_name == variable_name
+        ][0]
         for coordinate_name in temp_dataset.sizes:
             if coordinate_name == "elevation":
                 coordinate_name = "depth"
@@ -270,15 +273,14 @@ def get_approximation_size_data_downloaded(
                 for coordinate_names in COORDINATES_LABEL.values()
                 if coordinate_name in coordinate_names
             ][0]
-            coordinate = [
+            coordinates = [
                 coord
-                for coord in [
-                    var
-                    for var in service.variables
-                    if var.short_name == variable_name
-                ][0].coordinates
+                for coord in variable.coordinates
                 if coord.coordinate_id in possible_coordinate_id
-            ][0]
+            ]
+            if not coordinates:
+                continue
+            coordinate = coordinates[0]
             chunking_length = coordinate.chunking_length
             if not chunking_length:
                 continue