servo-service-over-can #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angstrem98
reviewed
Jan 19, 2022
…vo-service-over-can
Can read Position and Speed from servo, as well as the status message after GoalPosition command
Now more than one servo can work at the same time
angstrem98
reviewed
Jan 21, 2022
angstrem98
reviewed
Jan 21, 2022
angstrem98
reviewed
Jan 21, 2022
Should test the timeout for waiting servo response (0.1s for now)
angstrem98
reviewed
Jan 21, 2022
| try: | ||
| self.bus.send(msg) | ||
| except can.CanError: | ||
| self.get_logger().info("CAN ERROR: Nije poslata poruka") |
There was a problem hiding this comment.
Da sve u kodu bude na Engleskom možeš prepraviti ove log poruke na engleski, mada nije obavezno.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.