Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Add community calendar #18

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Add community calendar #18

merged 2 commits into from
Oct 27, 2023

Conversation

melissawm
Copy link
Owner

@melissawm melissawm commented Oct 20, 2023

May close #15

To try and make the stack as clean as possible while still keeping the community calendar nicely rendered in our pages, I've switched over from react-calendar to fullCalendar. This creates a different visual, but functionality is mostly there. fullCalendar is also being used by Scientific Python and I think going with a solution that is already used by the community can be interesting 😄

This PR is a work in progress, but I'd love to get some feedback on whether or not this is fine.

Here's how the rendered page looks like: https://melissawm.github.io/napari-theme-var/community/meeting_schedule.html

cc @jni

@jni
Copy link

jni commented Oct 21, 2023

Yeah I really like it! I love that we get list view "for free", and you've gotten the look really close! So 👍 from me!

@jni
Copy link

jni commented Oct 21, 2023

(And +💯 to using what the rest of the community is using! ❤️‍🔥)

@psobolewskiPhD
Copy link

Love it!
It fixes the Safari calendar issues!
This PR:
image
Live napari.org:
image

@psobolewskiPhD
Copy link

psobolewskiPhD commented Oct 27, 2023

Also, it's clipped in the screenshot, but the navigation at the bottom is fixed!
napari/napari-sphinx-theme#126
and the burger menu is fixed!
napari/napari-sphinx-theme#130

Glorious @melissawm We should aim for this for 0.5.0!

@melissawm
Copy link
Owner Author

melissawm commented Oct 27, 2023

Ok - missing is just the event popover: right now it looks very basic, but the information is there. I will merge and the missing piece here is changes that should happen on the napari/docs side. I will submit those once we have figured out the deployment for the napari-sphinx-theme package and any pending fixes.

@melissawm melissawm merged commit a7bbfd7 into main Oct 27, 2023
@melissawm melissawm deleted the add-calendar branch October 27, 2023 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded community calendar is missing
3 participants