Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect background corrections #353

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

talonchandler
Copy link
Collaborator

Fixes #349.

@edyoshikun I couldn't get DirectoryPath to work in the way you suggested, but I ended up finding a fairly simple method with os.path.isdir.

I've tested on hummingbird.

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/mehta-lab/recOrder/353
Created: 2023-04-25T17:37:51.882356

Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM!

@talonchandler talonchandler merged commit 23d8aa5 into 0.4.0dev Apr 26, 2023
@ziw-liu ziw-liu deleted the connect-bg-correction branch July 26, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants