Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background correction path problems #349

Closed
talonchandler opened this issue Apr 25, 2023 · 2 comments
Closed

Fix background correction path problems #349

talonchandler opened this issue Apr 25, 2023 · 2 comments
Assignees
Milestone

Comments

@talonchandler
Copy link
Collaborator

In my initial prototypes my background corrections strings weren't being passed correctly. After discussing with @ziw-liu and @edyoshikun I think I need to use str type and validate. I expect this to be a fairly shallow bug.

@talonchandler talonchandler added this to the 0.4.0 milestone Apr 25, 2023
@talonchandler talonchandler self-assigned this Apr 25, 2023
@edyoshikun
Copy link
Contributor

something like this

from pydantic import BaseModel, validator, DirectoryPath

class _BirefringenceApplyInverseSettings(BaseModel):
background_path: str = ''
    @validator('background_path')
    def check_dir_path(cls, v):
        return DirectoryPath().validate(v)

@talonchandler
Copy link
Collaborator Author

Fixed by #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants