Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Fixing Menus service remove bugs. #810

Merged
merged 1 commit into from
Aug 18, 2015

Conversation

cdriscol
Copy link
Contributor

Fixing Menus service removeMenuItem and removeSubMenuItem by..

  • modified tests to reproduce issues
  • replaced references to old link property with new state property

Fixes #777 and replaces #778.

@mleanos
Copy link
Member

mleanos commented Aug 16, 2015

LGTM. So much movement with the Menu's service lately :)

@codydaig
Copy link
Member

LGTM Tested and words as expected. Thanks @cdriscol!

@lirantal lirantal self-assigned this Aug 18, 2015
@lirantal
Copy link
Member

Great.
Thanks guys!

lirantal added a commit that referenced this pull request Aug 18, 2015
Fixing Menus service remove bugs.
@lirantal lirantal merged commit 793187c into meanjs:master Aug 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants