This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Fixing Menus service removeMenuItem and removeSubMenuItem #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… references to old link property.
|
LGTM. Verified that the new tests are passing. Thanks @cdriscol these tests are looking very nice. |
|
LGTM |
|
@cdriscol This PR has a merge conflict that needs to get resolved before it can be merged. |
Conflicts: modules/core/tests/client/menus.client.service.tests.js
|
Replaced by #810 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Menus service removeMenuItem and removeSubMenuItem by..
Fixes #777