This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
feat(users) Improved social login buttons UI #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm aware that this to some extent undoes the mobile grid layout pushed here #1427 Unfortunately this grid layout was off-center, the buttons were tiny on mobile, and also if a single button was removed (very likely that users won't want to authenticate through all 6 systems) the whole thing would look asymmetrical on either desktop or mobile + the HTML was hard to fix. |
hyperreality
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(users): Improved social login buttons UI
All social buttons are now responsive and display properly on mobile
The grid is not broken if one is removed
Cleaned up redundant CSS