Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

feat(users): Update social login design #1427

Closed
wants to merge 2 commits into from
Closed

Conversation

benobab
Copy link

@benobab benobab commented Aug 12, 2016

New design for social links

  • responsive images
  • grid for mobile layout as well

- Responsive images
- Mobile layout as well
@mleanos
Copy link
Member

mleanos commented Aug 14, 2016

LGTM. I've tested this as well.

Thanks @benobab!

@mleanos mleanos added this to the 0.5.0 milestone Aug 14, 2016
@hyperreality
Copy link
Contributor

hyperreality commented Aug 14, 2016

One small gripe I have with this commit is that it works great if you want to authenticate with all 6 networks, but in most cases that won't be true, and after removing a button or two it's hard to get a nice centred design.

Furthermore, I tried shrinking the page in Firefox and below a certain size it's not possible to click the buttons at all.

Also why we're at it why don't we make the buttons interactive? Add them to a 'social' class and put this in core.css:

.social {
   -webkit-transition-duration: 0.4s;
   -moz-transition-duration: 0.4s;
   -o-transition-duration: 0.4s;
   transition-duration: 0.4s;
}

.social:hover {
    opacity: 0.65;
}

@benobab
Copy link
Author

benobab commented Aug 14, 2016

@hyperreality I've updated the code with your css and fixed the bug where you can't click the buttons at all (xs rather than md for bootstrap).

@lirantal lirantal self-assigned this Aug 26, 2016
@lirantal lirantal mentioned this pull request Aug 26, 2016
@lirantal
Copy link
Member

Thanks a lot @benobab, I fixed the conflict and added to your commits a new PR which can be merged at: #1450

@lirantal
Copy link
Member

closed through PR #1450

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants