-
Notifications
You must be signed in to change notification settings - Fork 2k
Using both ESLint and JSHint #1072
Comments
@feimosi do you want to submit a PR to clean it up and add the angular eslint plugin? |
@lirantal sure, no problem. Should get rid of JSHint completely? |
If jshint is redundant then yes obviously remove it in favor of eslint. |
👍 |
I think the specific duplicates are just some rules we have in both places. I'm not sure if JSHint is has all the features JSHint has and more though, so that will need to be checked if we want to remove JSHint. |
That's the point, ESLint offers the same functionality and even more, so there's no point in using two linting tools. AFAIK it's closely compatible with JSHint, so most of the rules should be there. We just need to do the migration from |
@feimosi If it doesn't throw errors, that sounds good to me. Otherwise, we'll need to just discuss any changes extending an existing config. |
@feimosi we're waiting on that PR from you... :-) |
Add basic ESLint setup extending well-known Airbnb code style. Fixes meanjs#1072, meanjs#1097
Is it a good idea to keep both: ESLint and JSHint in the project? It'll print many duplicate linting errors to the console. Also ESLint haven't been attached to the gulp watchers. And lastly, as an enhancement, there's a great eslint-plugin-angular for linting Angular apps.
Referencing #990
The text was updated successfully, but these errors were encountered: