Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Using both ESLint and JSHint #1072

Closed
feimosi opened this issue Nov 27, 2015 · 8 comments
Closed

Using both ESLint and JSHint #1072

feimosi opened this issue Nov 27, 2015 · 8 comments
Assignees
Milestone

Comments

@feimosi
Copy link
Contributor

feimosi commented Nov 27, 2015

Is it a good idea to keep both: ESLint and JSHint in the project? It'll print many duplicate linting errors to the console. Also ESLint haven't been attached to the gulp watchers. And lastly, as an enhancement, there's a great eslint-plugin-angular for linting Angular apps.
Referencing #990

@lirantal lirantal added this to the 0.5.0 milestone Nov 28, 2015
@lirantal lirantal self-assigned this Nov 28, 2015
@lirantal
Copy link
Member

@feimosi do you want to submit a PR to clean it up and add the angular eslint plugin?

@feimosi
Copy link
Contributor Author

feimosi commented Nov 28, 2015

@lirantal sure, no problem. Should get rid of JSHint completely?

@lirantal
Copy link
Member

If jshint is redundant then yes obviously remove it in favor of eslint.

@codydaig
Copy link
Member

👍

@ilanbiala
Copy link
Member

I think the specific duplicates are just some rules we have in both places. I'm not sure if JSHint is has all the features JSHint has and more though, so that will need to be checked if we want to remove JSHint.

@feimosi
Copy link
Contributor Author

feimosi commented Nov 29, 2015

That's the point, ESLint offers the same functionality and even more, so there's no point in using two linting tools. AFAIK it's closely compatible with JSHint, so most of the rules should be there. We just need to do the migration from .jshintrc to .eslintrc. Preferably also add new rules, including code style, but that may need an additional discussion.
Also I think it wouldn't be a bad idea to use the 'extending config' feature from ESLint and use someone else's config as the base e.g. well-known Airbnb rules.
What do you say?

@ilanbiala
Copy link
Member

@feimosi If it doesn't throw errors, that sounds good to me. Otherwise, we'll need to just discuss any changes extending an existing config.

@lirantal
Copy link
Member

@feimosi we're waiting on that PR from you... :-)

HarryGogonis pushed a commit to HarryGogonis/mean that referenced this issue Mar 18, 2016
Add basic ESLint setup extending well-known Airbnb code style.

Fixes meanjs#1072, meanjs#1097
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants