This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
61 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
{ | ||
rules: { | ||
indent: [2, 2, {"SwitchCase": 1}], | ||
no-multi-spaces: 2, | ||
no-underscore-dangle: 0, | ||
no-use-before-define: [1, "nofunc"], | ||
no-unused-expressions: 0, | ||
no-empty-class: 0, | ||
object-curly-spacing: [2, "always"], | ||
quotes: [1, "single"], | ||
space-in-parens: [2, "never"] | ||
}, | ||
env: { | ||
node: true | ||
}, | ||
globals: { | ||
angular: true, | ||
$: true, | ||
jQuery: true, | ||
moment: true, | ||
window: true, | ||
document: true, | ||
Modernizr: true, | ||
__TESTING__: true, | ||
beforeEach: true, | ||
expect: true, | ||
describe: true, | ||
it: true, | ||
element: true, | ||
by: true, | ||
browser: true, | ||
inject: true, | ||
register: true, | ||
sinon: true, | ||
_: false | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5cc4b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a good idea to keep both: jslint and eslint? It'll print many duplicate linting errors to the console. Also you haven't attached eslint to gulp watchers. And lastly, there's a great eslint-plugin-angular for linting Angular apps.
What do you think?
Cheers.
d5cc4b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feimosi can you bring these concerns up in a new issue?
d5cc4b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I've just done it: #1072