Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Tapenade to latest version #29

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Updated Tapenade to latest version #29

merged 4 commits into from
Sep 8, 2023

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Aug 31, 2023

Purpose

Similar to mdolab/idwarp#89, this PR updates the differentiated files to the latest Tapenade version and adds a postprocessing step to remove non-standard type declarations.

Expected time until merged

2-3 days

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Current tests pass.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner August 31, 2023 22:39
@sseraj sseraj requested review from eirikurj and yqliaohk August 31, 2023 22:39
@sseraj sseraj mentioned this pull request Aug 31, 2023
13 tasks
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #29 (5b8ff3a) into main (fd7ac69) will not change coverage.
The diff coverage is n/a.

❗ Current head 5b8ff3a differs from pull request most recent head 073a19c. Consider uploading reports for the commit 073a19c to get more accurate results

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   50.11%   50.11%           
=======================================
  Files           5        5           
  Lines        1688     1688           
=======================================
  Hits          846      846           
  Misses        842      842           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sseraj
Copy link
Collaborator Author

sseraj commented Sep 8, 2023

This is ready for review

@yqliaohk yqliaohk merged commit e32268d into main Sep 8, 2023
@sseraj sseraj deleted the tapenade-update branch September 8, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants