Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to support CGNS 4.4 #28

Merged
merged 3 commits into from
Sep 9, 2023
Merged

Minor fix to support CGNS 4.4 #28

merged 3 commits into from
Sep 9, 2023

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Aug 26, 2023

Purpose

The CGNS library removed legacy constants. This change is backwards compatible with the CGNS version we currently support.

Expected time until merged

No rush

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner August 26, 2023 11:45
@eirikurj eirikurj requested review from anilyil and sseraj August 26, 2023 11:45
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #28 (fd6fd8c) into main (e32268d) will not change coverage.
The diff coverage is n/a.

❗ Current head fd6fd8c differs from pull request most recent head 28b017c. Consider uploading reports for the commit 28b017c to get more accurate results

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   50.11%   50.11%           
=======================================
  Files           5        5           
  Lines        1688     1688           
=======================================
  Hits          846      846           
  Misses        842      842           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@eirikurj
Copy link
Contributor Author

eirikurj commented Aug 28, 2023

I believe @sseraj was going to submit a PR with updated Tapenade

@sseraj
Copy link
Collaborator

sseraj commented Aug 31, 2023

The Tapenade PR is up at #29

@anilyil anilyil merged commit 725b16c into main Sep 9, 2023
@anilyil anilyil deleted the fixCGNS branch September 9, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants