Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telemetry): measure top-level menu link clicks #9938

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Nov 3, 2023

Summary

Problem

In #9918 we started measuring menu clicks, but we don't measure clicks on the top-level menu links (Blog, Play, AI Help) yet.

Solution

Extract a common component add measure these clicks as well.


How did you test this change?

Ran yarn && yarn dev with the following environment variables (in .env):

REACT_APP_GLEAN_DEBUG=true
REACT_APP_GLEAN_ENABLED=true

Then visited http://localhost:3000/en-US/, clicked on Blog, Play and AI Help and verified that these show up in our Glean debug pings viewer.

@caugner caugner requested a review from a team as a code owner November 3, 2023 13:40
@caugner caugner changed the title Measure top menu link clicks chore(telemetry): measure top-level menu link clicks Nov 3, 2023
@caugner caugner force-pushed the measure-top-menu-link-clicks branch from bb2e97a to b453b08 Compare November 3, 2023 13:50
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fiji-flo fiji-flo merged commit 9c176c0 into main Nov 3, 2023
@fiji-flo fiji-flo deleted the measure-top-menu-link-clicks branch November 3, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants