chore(telemetry): measure menu clicks #9918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiji-flo
reviewed
Oct 31, 2023
| @@ -58,6 +61,9 @@ export const Submenu = ({ | |||
| className={`submenu-item ${ | |||
| item.url.startsWith("https://") ? "external" : "" | |||
| }`} | |||
| onClick={() => | |||
| gleanClick(`${MENU.CLICK_SUBMENU}: ${item.url}`) | |||
There was a problem hiding this comment.
That's used in a lot of places, maybe we want to add something like gleanEnabled?
There was a problem hiding this comment.
Since we only measure clicks on submenu items with a url, this will effectively only measure clicks on the main menu and on the user menu. To distinguish these, I now added the menu id to the click source.
This reverts commit 9184fa9.
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We don't know how many users click on the menu items in the top navigation (main menu and user menu).
Solution
Add measurements.
How did you test this change?
Ran
yarn && yarn devwith the following environment variables (in.env):Then visited http://localhost:3000/en-US/, clicked on menu and submenu items and verified that these show up in our Glean debug pings viewer.