Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use .nvmrc for setup-node versions #12501

Merged
merged 2 commits into from
Apr 3, 2023
Merged

ci: use .nvmrc for setup-node versions #12501

merged 2 commits into from
Apr 3, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Apr 2, 2023

Description

ci: use .nvmrc for setup-node versions

Related issues and pull requests

Reflect mdn/content#24355.

@github-actions github-actions bot added the system Infrastructure and configuration for the project label Apr 2, 2023
@yin1999 yin1999 marked this pull request as ready for review April 2, 2023 09:08
@yin1999 yin1999 requested a review from a team as a code owner April 2, 2023 09:08
@fwqaaq
Copy link
Contributor

fwqaaq commented Apr 2, 2023

Why not switch yarn to pnpm, pnpm has faster speed.

@yin1999
Copy link
Member Author

yin1999 commented Apr 2, 2023

Why not switch yarn to pnpm, pnpm has faster speed.

We just have a vote on package manager, and we may switch to NPM. But it seems that some problems were encountered during the migration process (follow mdn/yari#2326, I'm not sure if this is a problem with aws lambda).

@fwqaaq
Copy link
Contributor

fwqaaq commented Apr 2, 2023

Why not switch yarn to pnpm, pnpm has faster speed.

We just have a vote on package manager, and we may switch to NPM. But it seems that some problems were encountered during the migration process (follow mdn/yari#2326).

It seems like it hasn't started yet

@yin1999
Copy link
Member Author

yin1999 commented Apr 2, 2023

It seems like it hasn't started yet

mdn/yari#6322

@caugner caugner merged commit 16b78c5 into mdn:main Apr 3, 2023
@caugner
Copy link
Contributor

caugner commented Apr 3, 2023

Thank you @yin1999! 🎉

@fwqaaq We will probably have migrated mdn/yari to npm by end of May 2023.

@yin1999 yin1999 deleted the use-nvm branch April 3, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants