ci: use .nvmrc for setup-node versions #24355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
FWIW node-version-file is documented here.
It also supports package.json, which might be preferable (so that it tests with the lowest version we support), but given our >=18.0.0 range, I'm not sure what version it would choose (18.0.0, latest 18.x.x or latest).
tl;dr These changes make sense, and avoid us having to touch the workflows when bumping Node.js.
caugner
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the
.nvmrcfile was added, makes sense to use it as the base for the CI operations. Not sure if there is any difference in the cache-key calculations when a major version changes, but that's pretty infrequentMotivation
Additional details
Related issues and pull requests