Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for HTMLElement.writingSuggestions #37036

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 1, 2024

@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Dec 1, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

Preview URLs

Flaws (1)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLElement
Title: HTMLElement
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/cancel_event does not exist

(comment last updated: 2024-12-16 20:28:50)

@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Dec 1, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 1, 2024 03:18
@skyclouds2001 skyclouds2001 requested review from a team as code owners December 1, 2024 03:18
@skyclouds2001 skyclouds2001 requested review from wbamberg and estelle and removed request for a team December 1, 2024 03:18
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the interface property is boolean, returning only true or false, not enumerated.

@wbamberg wbamberg removed their request for review December 4, 2024 00:50
@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Dec 14, 2024

the interface property is boolean, returning only true or false, not enumerated.

no, this property is a enumerated property, not a boolean property

  <div id="missing-value"></div>
  <div id="invalid-value" writingsuggestions="test"></div>
  <div id="empty-value" writingsuggestions=""></div>
  <div id="true-value" writingsuggestions="true"></div>
  <div id="false-value" writingsuggestions="false"></div>

image

see also its spec

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stand corrected. Thank you.

Thanks for the PR! 🎉

@estelle estelle merged commit 8d5d188 into mdn:main Dec 16, 2024
8 checks passed
@skyclouds2001 skyclouds2001 deleted the HTMLElement.writingSuggestions branch December 17, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for writingsuggestions attribute
2 participants