Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for the writingsuggestions HTML attribute #35445

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

captainbrosset
Copy link
Contributor

Description

This PR adds a new documentation page for the writingsuggestions global HTML attribute.

Motivation

The attribute is supported in Chromium and was added to BCD, but is missing from MDN.

Additional details

Related issues and pull requests

This depends on mdn/browser-compat-data#24121, which got merge, but isn't yet available in the release of BCD that MDN depends on.

@captainbrosset captainbrosset requested a review from a team as a code owner August 13, 2024 10:33
@captainbrosset captainbrosset requested review from estelle and removed request for a team August 13, 2024 10:33
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed labels Aug 13, 2024
Copy link
Contributor

github-actions bot commented Aug 13, 2024

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTML/Global_attributes/writingsuggestions
Title: writingsuggestions
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.global_attributes.writingsuggestions

(comment last updated: 2024-08-20 08:21:18)

Copy link
Contributor

@skyclouds2001 skyclouds2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the documentation should be place under files/en-us/web/html/global_attributes than files/en-us/web/html/attributes

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started a review last week but had to drop everything and was offline. Committing that review. It's for the outdated file location, but four comments are still valid.

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Aug 20, 2024
@captainbrosset captainbrosset requested a review from estelle August 20, 2024 08:20
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM! 🎉

@estelle estelle merged commit 87b1277 into mdn:main Aug 20, 2024
8 checks passed
@captainbrosset captainbrosset deleted the writingsuggestions branch August 21, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants