Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateText: Remove false information #36832

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

mikecat
Copy link
Contributor

@mikecat mikecat commented Nov 17, 2024

Description

Remove false information about when to throw exceptions.

Motivation

Additional details

Passing rangeStart that is greater than rangeEnd is explicitly allowed.

EditContext API

Note
It's permissible that rangeStart > rangeEnd. The substring between the indices should be replaced in the same way as when rangeStart <= rangeEnd.

Related issues and pull requests

@mikecat mikecat requested a review from a team as a code owner November 17, 2024 23:14
@mikecat mikecat requested review from sideshowbarker and removed request for a team November 17, 2024 23:14
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Nov 17, 2024
Copy link
Contributor

Preview URLs

@sideshowbarker sideshowbarker merged commit 7d7b014 into mdn:main Nov 17, 2024
7 checks passed
@mikecat mikecat deleted the remove-false-information branch November 17, 2024 23:20
wbamberg added a commit to wbamberg/content that referenced this pull request Nov 27, 2024
* origin/xss-guide: (284 commits)
  Add information on default entryPoint property values (mdn#36633)
  Bump husky from 9.1.6 to 9.1.7 (mdn#36863)
  fix(performance): Typo '50ms seconds' (mdn#36861)
  Add spec_url & add note for bcd for `<frequency>` and `<frequency-percentage>` (mdn#36848)
  addresses 36583: summary icon styles (mdn#36691)
  Remove "simple" part 3: change to "basic"  (mdn#36762)
  the default option of a select (mdn#36658)
  docs(css): Add support for `<string>` in `syntax` descriptor of @Property at-rule (mdn#36655)
  Fix parameter syntax for `Navigation.updateCurrentEntry()` (mdn#36852)
  Update CSP source expression reference (mdn#36792)
  chore(http): Refresh headers docs (d-k) (mdn#36075)
  chore(http): Refresh headers r-s (mdn#36590)
  Updated index.md (mdn#36845)
  fix : wrong method name (mdn#36843)
  Remove all redirects to other locales (mdn#36811)
  fix typos (mdn#36837)
  docs: update Accept-Charset status (mdn#36822)
  updateSelection: make more intuitive (mdn#36834)
  updateText: Remove false information (mdn#36832)
  DOMRect instance properties (mdn#36704)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants