Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addresses 36583: summary icon styles #36691

Merged
merged 6 commits into from
Nov 19, 2024
Merged

addresses 36583: summary icon styles #36691

merged 6 commits into from
Nov 19, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Nov 8, 2024

addresses concerned brought up in #36583

@estelle estelle requested a review from a team as a code owner November 8, 2024 08:34
@estelle estelle requested review from chrisdavidmills and removed request for a team November 8, 2024 08:34
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/m [PR only] 51-500 LoC changed labels Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Preview URLs

(comment last updated: 2024-11-19 12:39:46)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle A few bits for you to consider, but nothing major. Really nice examples!

files/en-us/web/html/element/details/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/details/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/summary/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/summary/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/summary/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/summary/index.md Outdated Show resolved Hide resolved
Copy link
Member Author

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

files/en-us/web/html/element/details/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/details/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/summary/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/summary/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/summary/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/summary/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle the updates are all looking good; let's get this merged!

@chrisdavidmills chrisdavidmills merged commit aee844b into main Nov 19, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the summary branch November 19, 2024 12:40
wbamberg added a commit to wbamberg/content that referenced this pull request Nov 27, 2024
* origin/xss-guide: (284 commits)
  Add information on default entryPoint property values (mdn#36633)
  Bump husky from 9.1.6 to 9.1.7 (mdn#36863)
  fix(performance): Typo '50ms seconds' (mdn#36861)
  Add spec_url & add note for bcd for `<frequency>` and `<frequency-percentage>` (mdn#36848)
  addresses 36583: summary icon styles (mdn#36691)
  Remove "simple" part 3: change to "basic"  (mdn#36762)
  the default option of a select (mdn#36658)
  docs(css): Add support for `<string>` in `syntax` descriptor of @Property at-rule (mdn#36655)
  Fix parameter syntax for `Navigation.updateCurrentEntry()` (mdn#36852)
  Update CSP source expression reference (mdn#36792)
  chore(http): Refresh headers docs (d-k) (mdn#36075)
  chore(http): Refresh headers r-s (mdn#36590)
  Updated index.md (mdn#36845)
  fix : wrong method name (mdn#36843)
  Remove all redirects to other locales (mdn#36811)
  fix typos (mdn#36837)
  docs: update Accept-Charset status (mdn#36822)
  updateSelection: make more intuitive (mdn#36834)
  updateText: Remove false information (mdn#36832)
  DOMRect instance properties (mdn#36704)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants