Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update landmark roles - add HTML <search> element #29121

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Sep 14, 2023

Description

Add the new <search> element to the landmark roles list.

Motivation

7/8 roles have HTML tags, the last one (search role) didn't.

Additional details

Related issues and pull requests

Relates to #27727 & mdn/browser-compat-data#19357

@ramiy ramiy requested a review from a team as a code owner September 14, 2023 18:21
@ramiy ramiy requested review from scottaohara and removed request for a team September 14, 2023 18:21
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Sep 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Preview URLs

(comment last updated: 2023-09-14 20:48:30)

@estelle
Copy link
Member

estelle commented Sep 14, 2023

We should definitely add the link to <search>, but we need to keep the list alphabetical.

@ramiy
Copy link
Contributor Author

ramiy commented Sep 14, 2023

Updated.

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 3c9e316 into mdn:main Sep 15, 2023
@ramiy ramiy deleted the patch-1 branch September 15, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants