Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML <search> element #27727

Merged
merged 6 commits into from
Jul 10, 2023
Merged

HTML <search> element #27727

merged 6 commits into from
Jul 10, 2023

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Jul 3, 2023 •
edited by Josh-Cena
Loading

@ramiy ramiy requested a review from a team as a code owner July 3, 2023 22:42
@ramiy ramiy requested review from estelle and removed request for a team July 3, 2023 22:42
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023 •
edited
Loading

Preview URLs

Flaws (1)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTML
Title: HTML: HyperText Markup Language
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Colors/Applying_color

(comment last updated: 2023-07-10 01:35:42)

@Josh-Cena
Copy link
Member

cc @domenic

@ramiy
Copy link
Contributor Author

ramiy commented Jul 4, 2023

Markdown lint - Multiple headings with the same content [Context: ### Result]

In other HTML element articles there are multiple headings with the same content, see the header tag.

@Josh-Cena
Copy link
Member

@ramiy The typical structure is to use H4 headings.

## Examples

### Doing something

#### HTML

#### Result

### Doing something else

#### HTML

#### Result

estelle
estelle requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this <search> element content. i made a few suggestions, and a fix for the prettier issues.

files/en-us/web/html/element/search/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/search/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/search/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/search/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/search/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/search/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/search/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/search/index.md Show resolved Hide resolved
files/en-us/web/html/element/search/index.md Outdated Show resolved Hide resolved
files/en-us/web/html/element/search/index.md Outdated Show resolved Hide resolved
estelle
estelle approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 667f693 into mdn:main Jul 10, 2023
@ramiy ramiy deleted the html-search-element branch July 10, 2023 07:50
@ramiy ramiy mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new <search> element to docs Document the <search> element
3 participants
@ramiy @Josh-Cena @estelle