Markdownlint: add custom rule to fix double spaces #20824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnkarRuikar
requested review from
hamishwillee
and removed request for
a team
Preview URLs (7 pages)
Flaws (1)Note! 6 documents with no flaws that don't need to be listed. 🎉 URL:
(this comment was updated 2022-10-10 03:21:09.101635) |
|
Prettier does this, so -0 on duplicating with a custom rule |
But Prettier is not going to get integrated soon. Not even in Q4. We can easily remove this after Prettier is automated. |
OnkarRuikar
force-pushed
the
custom_md_rule
branch
3 times, most recently
from
299a6ef to
6163552
Compare
OnkarRuikar
force-pushed
the
custom_md_rule
branch
from
1d25a16 to
d0eeacc
Compare
OnkarRuikar
requested review from
rebloor and
estelle
and removed request for
a team
github-actions
bot
added
Content:CSS
|
These are the new occurrences of the typo committed after the PR was opened. |
rebloor
approved these changes
Oct 10, 2022
estelle
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #17988
Description
Markdownlint doesn't flag/fix double spaces in text content. So we can add the capability to it using a custom rule.
Motivation
Issues like this pile up over time and lead to many drive by typo fix PRs.
Adding this to our custom rules collection will solve it for good.
Additional details
Note: We are not fixing it in code blocks, only in markdown text content.
cc/ @teoli2003, @nschonni