Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos: double spaces #20823

Merged
merged 5 commits into from
Sep 19, 2022
Merged

fix typos: double spaces #20823

merged 5 commits into from
Sep 19, 2022

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Sep 17, 2022 •
edited
Loading

Markdownlint doesn't flag/fix double spaces in text content.
The PR fixes them manually.

Note:

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner September 17, 2022 07:17
@OnkarRuikar OnkarRuikar requested a review from a team September 17, 2022 07:17
@OnkarRuikar OnkarRuikar requested review from a team as code owners September 17, 2022 07:17
@OnkarRuikar OnkarRuikar requested review from jpmedley, Josh-Cena, schalkneethling, estelle and hamishwillee and removed request for a team September 17, 2022 07:17
@github-actions github-actions bot added Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:JS JavaScript docs Content:Learn Learning area docs Content:MathML MathML docs Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs Content:wasm WebAssembly docs labels Sep 17, 2022
@github-actions github-actions bot added the Content:WebAPI Web API docs label Sep 17, 2022
@github-actions

This comment was marked as resolved.

Sign in to view
@OnkarRuikar OnkarRuikar mentioned this pull request Sep 17, 2022
Merged
@Josh-Cena
Copy link
Member

Note: these are fixable by Prettier

@rubiesonthesky
Copy link
Contributor

Prettier will not fix double spaces inside comments. It seems also that Prettier does not fix this one:

![  Screenshot of the DevTools console showing the correct version number.](version.png)

@OnkarRuikar
Copy link
Contributor Author

@Josh-Cena there is no harm in landing this.
Also, Prettier is not going to get integrated soon. May be not even in Q4.

@Josh-Cena
Copy link
Member

True, I'm not showing intent to block this or to suggest it's unnecessary. Just saying in the future it could be automated without all the extra work.

Josh-Cena
Josh-Cena approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in! We've all been there: I-am-Prettier...

files/en-us/web/javascript/reference/global_objects/array/grouptomap/index.md Outdated Show resolved Hide resolved
files/en-us/web/javascript/reference/global_objects/date/setdate/index.md Outdated Show resolved Hide resolved
@Josh-Cena Josh-Cena merged commit e1f571e into mdn:main Sep 19, 2022
@OnkarRuikar OnkarRuikar deleted the typo_spaces branch September 19, 2022 04:57
himanshugarg pushed a commit to himanshugarg/content that referenced this pull request Sep 27, 2022
@OnkarRuikar @Josh-Cena
fix typos: double spaces (mdn#20823)
2665aad 
* fix typos: double spaces

* more fixes

* more fixes

* Apply suggestions from code review

Co-authored-by: Joshua Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-web-api

@schalkneethling schalkneethling Awaiting requested review from schalkneethling schalkneethling is a code owner automatically assigned from mdn/yari-content-html

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-css

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:JS JavaScript docs Content:Learn Learning area docs Content:MathML MathML docs Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs Content:wasm WebAssembly docs Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnkarRuikar @Josh-Cena @rubiesonthesky