Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove confusion around private/public cache directive #17214

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Remove confusion around private/public cache directive #17214

merged 2 commits into from
Jun 13, 2022

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jun 13, 2022 •
edited
Loading

Fixes #17199

The section on the private cache control directive had an "aside" that indicated the public directive was not similar. However the text was confusing. Also unnecessary to the discussion of private caches.

So I stripped out the comparison of private to public from the private section and pushed it down to the only other section where public was mentioned.

@Jxck Could you please sanity check this change?

@hamishwillee hamishwillee requested a review from a team as a code owner June 13, 2022 00:31
@hamishwillee hamishwillee requested review from teoli2003 and removed request for a team June 13, 2022 00:31
@github-actions github-actions bot added the Content:HTTP HTTP docs label Jun 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2022 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/HTTP/Caching
Title: HTTP caching
on GitHub

No new external URLs

(this comment was updated 2022-06-13 06:03:30.727709)

@hamishwillee hamishwillee mentioned this pull request Jun 13, 2022
Closed
teoli2003
teoli2003 suggested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits and I think we can land this.

@Jxck
Copy link
Contributor

Jxck commented Jun 13, 2022

SGTM

teoli2003
teoli2003 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the nix and go ahead with the merging.

@teoli2003 teoli2003 merged commit 3d19223 into main Jun 13, 2022
@teoli2003 teoli2003 deleted the hamishwillee-patch-1 branch June 13, 2022 06:02
@hamishwillee
Copy link
Collaborator Author

Thanks for merging. Sorry, didn't look at my emails until now - head deep in byte streams.

@Jxck Jxck mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

Assignees
No one assigned
Labels
Content:HTTP HTTP docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Difficult to understand a sentence in Private Cache section
3 participants
@hamishwillee @Jxck @teoli2003