-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect description of HTTP Private Cache #29019
Comments
Hmmm, I thought Authorization was a request header, so either way this "reads wrong". @teoli2003 thoughts on this? |
I think I may have misread that a bit, but as you say, I think this is still wrong. As describe below, shared cache for request with Authorization header can be stored.
So I think you're right, the authorization is the request header. So the content should be changed to
The above is corrected by
If there are no issues after checking, can I send a PR on this? |
@shin-mallang Sure, once we know for sure a fix would be welcome. @teoli2003 is a resident expert, and we can also get advice from another person if he doesn't know. To me the text seems likely to be incorrect. If information is protected you don't want it stored in a shared cache, where it might be visible to users that did not originally have permission, unless it is explicitly marked as public. But a private cache should not have these risks. But you never know what we might be missing. Might take a few days for people to respond. |
Thanks for the answer |
@Jxck I was wondering if you could look at this and confirm if you are allowed to cache the result of an |
Hmm it seems wrong, and not my original intention. |
@hamishwillee @Jxck I'm just wondering if I'm understanding this situation correctly. Firstly, what was written in the docs was about If the above is correct, then my second question is, what is the statement about the My understanding is that because it's a Or did you have some sort of rationale for saying it can't be cached? Whatever it is, if it's not stated in the spec, I think it should be that it's not recommended to cache it, rather than that it can't be cached. |
@shin-mallang What @Jxck is saying is that the current text looks wrong. I injected it as part of #17214 when trying to clean up some confusing text (which I had forgotten). The text before was also probably not quite right. He is suggesting that we change this back to saying what it did in #17214 and after that try to make it readable again, without injecting the incorrect statement. I will have a look at this, probably on Friday. |
@hamishwillee |
So @Jxck The problematic change here was: From
TO
What did you intend to say in the original text - there is no point restoring the original because that also has the bit we are not sure about. Noting that a response cannot have an
|
Thank you for your reply. 🙇♂️ |
Yes and No We need to mention about
I also confused why it happen. My intention & what described in spec is how
Yes, I also believe Authorized response (corresponding response for request with I found previous sentence also require improve. |
@Jxck |
@shin-mallang @hamishwillee done. only removing mentioning to "private cache" seems fine. |
Awesome. Thank you. Comment added. |
Checked. |
MDN URL
https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching#private_caches
What specific section or headline is this issue about?
private_caches
What information was incorrect, unhelpful, or incomplete?
The following exists in the documentation
However, it didn't say anything about private cache and Authorization headers in RFC 9111.
Here's what RFC 9111 says.
A cache MUST NOT store a response to a request unless:
What did you expect to see?
I think this should be left out.
Am I misunderstanding RFC 9111?
Do you have any supporting links, references, or citations?
No response
Do you have anything more you want to share?
No response
The text was updated successfully, but these errors were encountered: