Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data for Payment APIs #6679

Merged
merged 8 commits into from
Sep 22, 2020
Merged

Update data for Payment APIs #6679

merged 8 commits into from
Sep 22, 2020

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Sep 13, 2020

When pulling data from the mdn-bcd-collector project I've been working on, I noticed a few odd discrepancies with data reported by the collector and BCD's data. It turns out that support for the Payment APIs is in more browsers than we initially thought. This PR does the following to fix these discrepancies, plus adjust our data in a desirable way:

  1. Updates the data to reflect what was found based upon testing with the collector and manual testing (Opera, Opera Android, and Samsung Internet all support the APIs, apparently -- WebView has partial API support, though this is probably not intentional)
  2. Removes repeated flag information for the API's subfeatures (we don't need to mention the flag for PaymentResponse.complete, for example, when PaymentResponse already has it)

The data for these interfaces was, to put it simply, quite the mess. This PR hopefully resolves the mess.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 13, 2020
@foolip
Copy link
Collaborator

foolip commented Sep 14, 2020

Removes repeated flag information for the API's subfeatures (we don't need to mention the flag for PaymentResponse.complete, for example, when PaymentResponse already has it)

This bit I'm not sure about. It seems to me like it will make the data incorrect, I'll comment inline.

api/PaymentResponse.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed part of it, have to run!

api/AbortPaymentEvent.json Show resolved Hide resolved
api/PaymentAddress.json Show resolved Hide resolved
api/PaymentAddress.json Show resolved Hide resolved
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaalmost ready to merge.

api/PaymentAddress.json Show resolved Hide resolved
api/PaymentResponse.json Outdated Show resolved Hide resolved
api/AbortPaymentEvent.json Outdated Show resolved Hide resolved
@foolip foolip merged commit 2cf706b into mdn:master Sep 22, 2020
@queengooborg queengooborg deleted the api/Payment branch September 22, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants