Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported features should not have flag/partial_implementation data #6742

Closed
queengooborg opened this issue Sep 21, 2020 · 2 comments · Fixed by #15551 or #15816
Closed

Unsupported features should not have flag/partial_implementation data #6742

queengooborg opened this issue Sep 21, 2020 · 2 comments · Fixed by #15551 or #15816
Assignees
Labels
enhancement Nice to have features. linter Issues or pull requests regarding the tests / linter of the JSON files. schema Isses or pull requests regarding the JSON schema files used in this project.

Comments

@queengooborg
Copy link
Collaborator

queengooborg commented Sep 21, 2020

When working on #6679, I noticed that the linter doesn't prevent features with "version_added": false from having flags, partial_implementation, prefix, or alternative_name. I don't think that it makes sense for an unsupported feature to have anything other than a note. We should add statements to the linter that prevent flags/partial implementation if support is false.

@queengooborg queengooborg added enhancement Nice to have features. linter Issues or pull requests regarding the tests / linter of the JSON files. labels Sep 21, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 3, 2020

Something that would be helpful to move on this: how many features are currently affected by this. If there are few (or no) features with "version_added": false and unexpected fields, then it's pretty easy to change the schema to prevent it. If not, there's a data quality project to work on before we can clamp down the schema.

@ddbeck ddbeck added the schema Isses or pull requests regarding the JSON schema files used in this project. label Nov 3, 2020
@ddbeck ddbeck reopened this Apr 12, 2022
@ddbeck
Copy link
Collaborator

ddbeck commented Apr 12, 2022

This wasn't resolved by #15551. The PR did remove the data, but didn't change the schema or linting to prevent it from happening in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Nice to have features. linter Issues or pull requests regarding the tests / linter of the JSON files. schema Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
3 participants
@ddbeck @queengooborg and others