-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating :matches() to :is(), as per spec change #3092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only browser actually shipping this is currently only Safari.
review?(@jpmedley, @erikadoyle)
"support": { | ||
"chrome": [ | ||
{ | ||
"version_added": "66" | ||
"version_added": "66", | ||
"alternative_name": ":matches()" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a flag.
} | ||
], | ||
"edge": [ | ||
{ | ||
"version_added": "15" | ||
"version_added": "15", | ||
"alternative_name": ":matches()" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Happy to update this if Joe and Erika confirm the details ;-) I can do some digging if needed, but I've run out of time for now. |
This will conflict with #2937 |
Well then we should probably merge #2937 first (I had completely forgoten about its existence), as it corrects the data, and then rebase this on top of it. |
@chrisdavidmills I'm sorry #2937 took so long. Can you rebase this PR now? Thank you! |
I can't work out how to rebase this correctly. I've just spent half an hour trying to do this and got myself in a complete mess. I'm just going to close this and make the changes in a new PR, which would've taken me 15 minutes if I'd just done that in the first place. |
As per w3c/csswg-drafts#3258