Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating :matches() to :is(), as per spec change #3092

Closed
wants to merge 1 commit into from
Closed

updating :matches() to :is(), as per spec change #3092

wants to merge 1 commit into from

Conversation

chrisdavidmills
Copy link
Contributor

Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only browser actually shipping this is currently only Safari.

review?(@jpmedley, @erikadoyle)

"support": {
"chrome": [
{
"version_added": "66"
"version_added": "66",
"alternative_name": ":matches()"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a flag.

}
],
"edge": [
{
"version_added": "15"
"version_added": "15",
"alternative_name": ":matches()"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@chrisdavidmills
Copy link
Contributor Author

Happy to update this if Joe and Erika confirm the details ;-)

I can do some digging if needed, but I've run out of time for now.

@Elchi3 Elchi3 added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Nov 16, 2018
@Elchi3
Copy link
Member

Elchi3 commented Nov 30, 2018

This will conflict with #2937

@ExE-Boss
Copy link
Contributor

Well then we should probably merge #2937 first (I had completely forgoten about its existence), as it corrects the data, and then rebase this on top of it.

@Elchi3
Copy link
Member

Elchi3 commented Feb 1, 2019

@chrisdavidmills I'm sorry #2937 took so long. Can you rebase this PR now? Thank you!

@chrisdavidmills
Copy link
Contributor Author

I can't work out how to rebase this correctly. I've just spent half an hour trying to do this and got myself in a complete mess. I'm just going to close this and make the changes in a new PR, which would've taken me 15 minutes if I'd just done that in the first place.

@chrisdavidmills chrisdavidmills deleted the matches-to-is branch February 1, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants