update CSS :matches() #2937
Merged
update CSS :matches() #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed Chrome status claiming support is shipped in Chrome 66. added flags and notes to show it is behind the flag and has partial support.
Those implementation was based on the old spec.
addresses linting error.
Elchi3
added
the
data:css
jpmedley
suggested changes
Oct 10, 2018
ExE-Boss
suggested changes
Oct 10, 2018
jpmedley
suggested changes
Oct 15, 2018
|
NP. The link is what I'll be asking for going forward. |
|
@ExE-Boss does it look alright to you know? r? |
ExE-Boss
approved these changes
Jan 31, 2019
css/selectors/matches.json
Outdated
| "edge_mobile": { | ||
| "version_added": false | ||
| }, | ||
| "firefox": { | ||
| "version_added": "4", | ||
| "alternative_name": ":-moz-any" | ||
| "alternative_name": ":-moz-any", | ||
| "notes": "Doesn't support combinators." |
There was a problem hiding this comment.
Nit: Consider adding a link to bug 906353:
Suggested change
| "notes": "Doesn't support combinators." | |
| "notes": [ | |
| "Doesn't support combinators.", | |
| "See <a href='https://bugzil.la/906353>bug 906353</a>" | |
| ] |
There was a problem hiding this comment.
Added. (GitHub didn't offer me to accept your suggestion directly, as I'm not the PR author. [I think they should allow maintainers to accept these, too])
|
Sorry this took a while! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:-moz-any()and:-webkit-any()are subset of:matches()