-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.31.6.0: Adds implicit and explicit conversions from double[][] to F64Matrix #124
Conversation
@jameschch I think this is a good idea. Even though it is a bit memory heavy to convert between Maybe you could add similar methods for supporting multidim arrays |
src/SharpLearning.Neural.Test/Learners/ClassificationNeuralNetLearnerTest.cs
Outdated
Show resolved
Hide resolved
src/SharpLearning.Neural.Test/Learners/ClassificationNeuralNetLearnerTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameschch Additions looks good. Just need to fix a few small nit picks :-).
Thanks for contributing with this!
Build seems to be failing after I added some line breaks. |
@jameschch Failing tests seems to be unrelated to your changes, so the failing build is most likely caused by some unstable unit tests. I will have a look at it later this week. |
@jameschch Since the checks fails because of flaky unit tests, I think we should just merge this, and I can look into the flaky tests in another PR. If you increment the version from |
@jameschch I have completed the pull request. Thanks for the contribution! packages should be up shortly. best regards |
This is a simple way to address the need to expose an API surface that accepts double[][] rather than an F64Matrix. Instead of changing all interfaces and implementations, I have made double[][] implicitly convertible to F64Matrix. This can be considered a convenience and a temporary workaround for #20 and #115 .