-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace SharpLearning.Containers.Matrices.F64Matrix with multidimensional array #20
Comments
Another idea, is to let the BTW, congrats on creating the first .NET ML library that actually makes sense through-and-through. |
Hi @diegoful, Thanks for joining and adding to the discussion. Also, thanks for the kind words! I am glad that you find SharpLearning useful and that the design makes sense. Using the Currently I am also considering to use the tensor type Microsoft is introducing. If this becomes a standard part of .net, i think it would make sense to use that implementation. This would also be useful when dealing with higher dimensional data for deep learning algorithms. My hope is that other libraries, like Math.net, would also adapt some interfacing to this type, if it becomes standard. best regards |
In SharpLearning, the F64Matrix class, which is part of the Learner interfaces, is mostly used as a container for holding the features for a learning problem. While SharpLearning does contain some arithmetic extensions for the F64Matrix, the arithmetic is not used by any of the learners. Also, more efficient implementations can be found in Math.net.
Therefore it might indicate, that the primary container for features in SharpLearning should rather be a standard .net type like multidimensional array (double[,]) or jagged array (double[][]), with some extension methods to add the current functionality of the F64Matrix.
An alternative, also suggested in #6, would be to replace the F64Matrix directly by using Math.net as the matrix provider. However, since only the SharpLearning.Neural project is using matrix arithmetic and with the plan of using CNTK as backend, math.net is a large dependency to take, if only using the matrix class as a feature container. So currently, I am leaning more towards replacing F64Matrix with a standard .net type. However, to better handle integration between Math.Net and SharpLearning, maybe a separate project, SharpLearning.MathNet, could be added with efficient conversions between Math.net and SharpLearning containers (both copy and shared memory). This of course depends on what data structure ends up replacing F64Matrix, if any.
These are my current thoughts, and people are very welcome to discuss and pitch in with suggestions.
The text was updated successfully, but these errors were encountered: