New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(time format): fix order time format #2

Open

mcspach wants to merge 1 commit into master from fix_order_time_30

Owner

mcspach commented Jun 24, 2021

Changes

Added function called formatDigits which always returns a two-digit number
Applied the function to hours, seconds, and minutes in render

Purpose

Order Time should be correctly formatted in hh:mm:ss format.

Approach

The dates will now include six digits at all times

Learning

Researched best practices, didn't find what I was looking for.
Read through MDN to understand more about Date() and Time() get methods
Decided easiest solution was write a short function to format each number

inspiration for the simplest function:
https://electrictoolbox.com/pad-number-two-digits-javascript/

If this closes an issue, reference the issue here. If it doesn't, remove this line
Closes Shift3#30


          fix(time format): fix order time format

86217f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet