Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Order Time does not format time correctly #30

Open
coreyshuman opened this issue Feb 12, 2020 · 0 comments · Fixed by ManishShiwlani/react-challenge-project#4 · 4 remaining pull requests
Open

Bug: Order Time does not format time correctly #30

coreyshuman opened this issue Feb 12, 2020 · 0 comments · Fixed by ManishShiwlani/react-challenge-project#4 · 4 remaining pull requests
Labels
challenge task This task is part of the react challenge.

Comments

@coreyshuman
Copy link
Member

Expected Behavior/Desired Use Case

Order Time should be correctly formatted in hh:mm:ss format.

Actual/Current Behavior

Order Time does not zero-pad minute and seconds correctly, so it will sometimes show invalid time formats such as this example:

Screen Shot 2020-02-11 at 8 03 23 PM

Steps to Reproduce the Problem/Implement this feature

  1. Create an order when the current time minutes or seconds is less than 10.

Learning

This is a common type of problem when time parsing is done manually instead of using built-in time formatting tools. Research best-practices for displaying time in the current stack and apply those best practices to this project.

@coreyshuman coreyshuman added good first issue Good for newcomers challenge task This task is part of the react challenge. and removed good first issue Good for newcomers labels Feb 12, 2020
MatthewCoatney added a commit to MatthewCoatney/react-challenge-project that referenced this issue Jul 7, 2021
22antonio added a commit to 22antonio/react-challenge-project that referenced this issue Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment